stage2 LLVM debug info #11085
Merged
stage2 LLVM debug info #11085
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This commit also adds a bunch of bindings for debug info.
also fix issue with memoization and recursiveness.
Also make `namespaceToDebugScope` behave correctly for file-level structs. Instead of being inside their own scope, they use the file scope.
Previously, we did this so that we could insert a debug variable declaration intrinsic on the alloca. But there is a dbg.value intrinsic for declaring variables that are values.
Also fix UAF of Type memory in the di_type_map.
This required adjusting `Type.nameAlloc` to be used with a general-purpose allocator and added `Type.nameAllocArena` for the arena use case (avoids allocation sometimes).
andrewrk
force-pushed
the
llvm-debug-info
branch
from
f7b3f4e to
fb4ad37
Compare
This was referenced Mar 8, 2022
|
Additional tests performed locally: I ran the behavior tests natively (x86_64-linux) with a debug build of LLVM and it did not trip any assertions. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Merge Checklist:
implement structsimplement debug info for structs in the llvm backend #11095implement unionsimplement debug info for unions in the llvm backend #11096implement local variablesemit DWARF .debug_info for local variables #6014implement global variablesimplement debug info for global variables in the llvm backend #11097Type.nameAlloc)