use * for pointer type instead of & #1032
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
See #770 To help automatically translate code, see the zig-fmt-pointer-reform-2 branch. This will convert all & into *. Due to the syntax ambiguity (which is why we are making this change), even address-of & will turn into *, so you'll have to manually fix thes instances. You will be guaranteed to get compile errors for them - expected 'type', found 'foo'
|
Hm, I just realized that AppVeyor has not been running since the rename from zig-lang. Fixing now. |
|
All checks passed. I will merge this tomorrow morning. |
|
@Hejsil I'd be happy to deal with merging master into |
|
@andrewrk Sure thing. Idk if I got all redundant builtin removed, but I guess that can wait :) |
|
Ok, I pushed |
|
I think this can be fixed to actually use nullables now: |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is part of Pointer Reform (See #770).
To help automatically translate code, see the
zig-fmt-pointer-reform-2branch. It will convert all&into*. Due to the syntaxambiguity (which is why we are making this change),
even address-of
&will turn into*, so you'll haveto manually fix these instances. You will be guaranteed
to get compile errors for them -
expected 'type', found 'foo'This fixes the cause of a lot of comptime bugs - the fact that
you could not have a pointer to a type (See #588)
This patch does not implement a new pointer type. It only changes the syntax and then fixes the bugs that were caused by the syntactic ambiguity. Further progress on Pointer Reform will happen gradually.