Add documentation for sentinel-terminated slicing #10010
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
marler8997
reviewed
Oct 27, 2021
andrewrk
requested changes
Oct 27, 2021
There was a problem hiding this comment.
Thanks @MichaelByrneAU - just a few suggestions and then I think this is ready to land.
Co-authored-by: Andrew Kelley <[email protected]>
Co-authored-by: Andrew Kelley <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Some additional documentation touching upon sentinel-terminated slicing. This should close #9680.
I've tried to keep this brief and consistent with the level of detail presented for similar sections. Happy to incorporate feedback or correct any inaccuracies in the description.