Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

translate-c incorrectly translates c_void ptr cast #4071

Closed
momumi opened this issue Jan 4, 2020 · 0 comments · Fixed by #9092
Closed

translate-c incorrectly translates c_void ptr cast #4071

momumi opened this issue Jan 4, 2020 · 0 comments · Fixed by #9092
Labels
contributor friendly This issue is limited in scope and/or knowledge of Zig internals. frontend Tokenization, parsing, AstGen, Sema, and Liveness. translate-c C to Zig source translation feature (@cImport)
Milestone
0.9.0

Comments

@momumi
Copy link
Contributor

momumi commented Jan 4, 2020 

#define MAP_FAILED	((void *) -1)

gets translated to

pub const MAP_FAILED = [*c]void - 1;
@daurnimator daurnimator added the translate-c C to Zig source translation feature (@cImport) label Jan 4, 2020
@andrewrk andrewrk added contributor friendly This issue is limited in scope and/or knowledge of Zig internals. frontend Tokenization, parsing, AstGen, Sema, and Liveness. labels Jan 5, 2020
@andrewrk andrewrk added this to the 0.7.0 milestone Jan 5, 2020
@andrewrk andrewrk modified the milestones: 0.7.0, 0.8.0 Aug 13, 2020
@Vexu Vexu mentioned this issue Feb 25, 2021
Closed
@Vexu Vexu mentioned this issue Mar 10, 2021
Closed
jmc-88 added a commit to jmc-88/zig that referenced this issue Apr 18, 2021
@jmc-88
translate-c: handle (type)unary_expr casts
91faadd 
Fixes ziglang#4071.

Previously, this code would treat unary operators immediately following
the `(type)` cast as part of a binary expression, producing nonsensical
Zig code as output. This change allows translate-c to parse such
operator as part of a unary expression following the type cast instead.
@Vexu Vexu mentioned this issue Apr 22, 2021
Closed
@xackus xackus mentioned this issue May 14, 2021
Closed
@andrewrk andrewrk modified the milestones: 0.8.0, 0.10.0 May 19, 2021
@xackus xackus mentioned this issue Jun 12, 2021
Merged
@Vexu Vexu modified the milestones: 0.10.0, 0.9.0 Jun 13, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
contributor friendly This issue is limited in scope and/or knowledge of Zig internals. frontend Tokenization, parsing, AstGen, Sema, and Liveness. translate-c C to Zig source translation feature (@cImport)
Projects
None yet
Milestone
0.9.0
Development

Successfully merging a pull request may close this issue.

translate-c: improve type parsing xackus/zig
4 participants
@andrewrk @daurnimator @Vexu @momumi