Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

@errSetCast refuses to accept an error union operand #17343

Closed
andrewrk opened this issue Oct 1, 2023 · 1 comment · Fixed by #17346
Closed

@errSetCast refuses to accept an error union operand #17343

andrewrk opened this issue Oct 1, 2023 · 1 comment · Fixed by #17346
Labels
bug Observed behavior contradicts documented or intended behavior frontend Tokenization, parsing, AstGen, Sema, and Liveness.
Milestone
0.12.0

Comments

@andrewrk
Copy link
Member

andrewrk commented Oct 1, 2023

Zig Version

0.12.0-dev.695+303181901

Steps to Reproduce and Observed Behavior

const std = @import("std");

test {
    const bar: error{Bad}!i32 = @errSetCast(foo());
    std.testing.expect((try bar) == 1234);
}

fn foo() anyerror!i32 {
    return 1234;
}
$ stage4/bin/zig test test.zig 
test.zig:4:33: error: expected error set type, found 'i32'
    const bar: error{Bad}!i32 = @errSetCast(foo());
                                ^~~~~~~~~~~~~~~~~~

Expected Behavior

Test passed.
@andrewrk andrewrk added bug Observed behavior contradicts documented or intended behavior frontend Tokenization, parsing, AstGen, Sema, and Liveness. labels Oct 1, 2023
@andrewrk andrewrk added this to the 0.12.0 milestone Oct 1, 2023
andrewrk added a commit that referenced this issue Oct 1, 2023
@andrewrk
std: add type-erased reader; base GenericReader on it
01ccc73 
The idea here is to avoid code bloat by having only one actual io.Reader
implementation, which is type erased, and then implement a GenericReader
that preserves type information on top of that as thin glue code.

The strategy here is for that glue code to `@errSetCast` the result of
the type-erased reader functions, however, while trying to do that I
ran into #17343.
This was referenced Oct 1, 2023
Merged
Merged
Vexu added a commit to Vexu/zig that referenced this issue Oct 1, 2023
@Vexu
Sema: implement @errSetCast for error unions
126180c 
Closes ziglang#17343
@Vexu Vexu mentioned this issue Oct 1, 2023
Merged
Vexu added a commit to Vexu/zig that referenced this issue Oct 1, 2023
@Vexu
Sema: add @errorCast which works for both error sets and error unions
a7479ef 
Closes ziglang#17343
Vexu added a commit to Vexu/zig that referenced this issue Oct 1, 2023
@Vexu
Sema: add @errorCast which works for both error sets and error unions
63bd2bf 
Closes ziglang#17343
@andrewrk
Copy link
Member Author

andrewrk commented Oct 1, 2023 •
edited
Loading

Follow-up issues:

andrewrk added a commit that referenced this issue Oct 1, 2023
@andrewrk
std: add type-erased reader; base GenericReader on it
5405444 
The idea here is to avoid code bloat by having only one actual io.Reader
implementation, which is type erased, and then implement a GenericReader
that preserves type information on top of that as thin glue code.

The strategy here is for that glue code to `@errSetCast` the result of
the type-erased reader functions, however, while trying to do that I
ran into #17343.
andrewrk added a commit that referenced this issue Oct 3, 2023
@andrewrk
std: add type-erased reader; base GenericReader on it
a6e915c 
The idea here is to avoid code bloat by having only one actual io.Reader
implementation, which is type erased, and then implement a GenericReader
that preserves type information on top of that as thin glue code.

The strategy here is for that glue code to `@errSetCast` the result of
the type-erased reader functions, however, while trying to do that I
ran into #17343.
andrewrk added a commit that referenced this issue Oct 3, 2023
@andrewrk
std: add type-erased reader; base GenericReader on it
2c2a5e6 
The idea here is to avoid code bloat by having only one actual io.Reader
implementation, which is type erased, and then implement a GenericReader
that preserves type information on top of that as thin glue code.

The strategy here is for that glue code to `@errSetCast` the result of
the type-erased reader functions, however, while trying to do that I
ran into #17343.
andrewrk added a commit that referenced this issue Oct 3, 2023
@andrewrk
std: add type-erased reader; base GenericReader on it
d8540dd 
The idea here is to avoid code bloat by having only one actual io.Reader
implementation, which is type erased, and then implement a GenericReader
that preserves type information on top of that as thin glue code.

The strategy here is for that glue code to `@errSetCast` the result of
the type-erased reader functions, however, while trying to do that I
ran into #17343.
krichprollsch added a commit to lightpanda-io/zig-js-runtime that referenced this issue Dec 4, 2023
@krichprollsch
@errSetCast is renamed into @errorcast
4aaf97b 
Relates to ziglang/zig#17343
krichprollsch added a commit to lightpanda-io/browser that referenced this issue Dec 4, 2023
@krichprollsch
@errSetCast is now @errorcast
ebafd59 
see ziglang/zig#17343
krichprollsch added a commit to lightpanda-io/browser that referenced this issue Dec 4, 2023
@krichprollsch
@errSetCast is now @errorcast
1328ea7 
see ziglang/zig#17343
krichprollsch added a commit to lightpanda-io/zig-js-runtime that referenced this issue Dec 4, 2023
@krichprollsch
@errSetCast is renamed into @errorcast
34ff98f 
Relates to ziglang/zig#17343
krichprollsch added a commit to lightpanda-io/browser that referenced this issue Dec 4, 2023
@krichprollsch
@errSetCast is now @errorcast
61470c3 
see ziglang/zig#17343
krichprollsch added a commit to lightpanda-io/browser that referenced this issue Dec 5, 2023
@krichprollsch
@errSetCast is now @errorcast
d73a204 
see ziglang/zig#17343
TUSF pushed a commit to TUSF/zig that referenced this issue May 9, 2024
@Vexu
Sema: add @errorCast which works for both error sets and error unions
0adbfc2 
Closes ziglang#17343
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
bug Observed behavior contradicts documented or intended behavior frontend Tokenization, parsing, AstGen, Sema, and Liveness.
Projects
None yet
Milestone
0.12.0
Development

Successfully merging a pull request may close this issue.

Sema: implement @errSetCast for error unions Vexu/zig
1 participant
@andrewrk