Skip to content

Commit

Permalink
glibc: fix race condition when building stubs
Browse files Browse the repository at this point in the history
Before, the code for building glibc stubs used a special case of the
Cache API that did not add any file inputs, and did not use
writeManifest(). This is not really how the Cache API is designed to
work and it shows because there was a race condition.

This commit adds as an input file the abilists file that comes with
Zig's installation, which has the added benefit of making glibc stub
caching properly detect cache invalidation when the user decides to
overwrite their abilists file. This harmonizes with the rest of how Zig
works, which intentionally allows you to hack the installation files and
have it behave properly with the cache system.

Finally, because of having any file inputs, the normal API flow of the
Cache system can be used, eliminating the one place that used the Cache
API in a special way. In other words, it uses writeManifest() now and
properly obeys the cache hit/miss semantics.

closes #13160
  • Loading branch information
andrewrk committed Oct 29, 2022
1 parent c36eb4e commit d6c57d1
Show file tree
Hide file tree
Showing 2 changed files with 343 additions and 349 deletions.
Loading

0 comments on commit d6c57d1

Please sign in to comment.