config: enable auto detection by default #80
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
zherczeg
reviewed
Aug 13, 2020
zherczeg
reviewed
Aug 18, 2020
zherczeg
requested changes
Aug 27, 2020
|
The last variant is still incorrect. You can define these with the value of 0, and that is the same thing as being not defined. I have proposed a variant above, that should not have this weakness. |
carenas
force-pushed
the
auto
branch
2 times, most recently
from
1f6bfa6 to
1abc0ec
Compare
carenas
commented
Aug 27, 2020
carenas
force-pushed
the
auto
branch
2 times, most recently
from
7234680 to
d19da41
Compare
carenas
changed the title
carenas
changed the title
zherczeg
reviewed
Aug 28, 2020
instead of requiring -DSLJIT_CONFIG_AUTO to enable, do autodetection unless a specific definition was used or auto detection was explicitly disabled by using -DSLJIT_CONFIG_AUTO=0
fengjixuchui
added a commit
to fengjixuchui/sljit
that referenced
this pull request
Aug 28, 2020
config: enable auto detection by default (zherczeg#80)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
instead of needing -DSLJIT_CONFIG_AUTO or some other definition, do auto detection unless a specific definition was passed or it was explicitly disabled by -DSLJIT_CONFIG_AUTO=0
in platforms (ex: armel or armhf) where there might be multiple possible targets to chose (ex: thumb2, v5 or v7) allows reconfiguring the build without having to edit the makefile, for example:
additionally, this allows to generate code for a different (but compatible) ABI (ex: ARM EABI 5 application generating Thumb2 code in an arm64 CPU/OS)