-
-
Notifications
You must be signed in to change notification settings - Fork 510
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
SegFault in latest main.c::change_winsize #41
Labels
Comments
Thanks. |
Need to check the value of tty, if it is NULL, return directly. |
Can you make a PR to fix it? |
I tested your fix, and it works fine. I'm fine with your pushing the fix into the repo directly; I don't need the credit. |
zhaojh329
pushed a commit
that referenced
this issue
Apr 12, 2019
Signed-off-by: Jianhui Zhao <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
The function main.c::change_winsize segfault, caused by NULL tty.
This is easily reproducible by symlink /bin/login to a shell script that exits immediately without doing anything.
The underlaying sequence appears to be
The text was updated successfully, but these errors were encountered: