Fix debug postfix in pkgconfig file #363
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
In case of USE_POSTFIX, the POSTFIX is dependent
on the CMAKE_BUILD_TYPE.
Use the correct POSTFIX also in the generated pugixml.pc file.
This results in the following contents of pugixml.pc:
- Release:
Libs: -L${libdir} -lpugixml
- RelWithDebInfo
Libs: -L${libdir} -lpugixml_r
- MinSizeRel:
Libs: -L${libdir} -lpugixml_m
- Debug:
Libs: -L${libdir} -lpugixml_d
c72578
added a commit
to c72578/vcpkg
that referenced
this pull request
Jul 15, 2020
- Add missing vcpkg_fixup_pkgconfig(), which was detected in microsoft#12151 - Fix debug POSTFIX in pugixml.pc file using pugixml-v1.10_fix_debug_pkgconfig.patch based on upstream: zeux/pugixml#363 This results in the following contents of pugixml.pc: Release: Libs: -L${libdir} -lpugixml Debug: Libs: -L${libdir} -lpugixml_d
|
Thanks! |
ras0219-msft
pushed a commit
to microsoft/vcpkg
that referenced
this pull request
Jul 15, 2020
- Add missing vcpkg_fixup_pkgconfig(), which was detected in #12151 - Fix debug POSTFIX in pugixml.pc file using pugixml-v1.10_fix_debug_pkgconfig.patch based on upstream: zeux/pugixml#363 This results in the following contents of pugixml.pc: Release: Libs: -L${libdir} -lpugixml Debug: Libs: -L${libdir} -lpugixml_d
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In case of
USE_POSTFIX, thePOSTFIXis dependenton the
CMAKE_BUILD_TYPE.Use the correct
POSTFIXalso in the generatedpugixml.pcfile.This results in the following contents of
pugixml.pc:Libs: -L${libdir} -lpugixmlLibs: -L${libdir} -lpugixml_rLibs: -L${libdir} -lpugixml_mLibs: -L${libdir} -lpugixml_d