Fix linking, running tests, etc. #49
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR fixes #48 .
Allows running tests before the shared libraries (particularly important for dependencies) are installed - matters if one wants to ensure things work before installing binaries system-wide. Fix is linking tests (
test_libopenabeand such) to the static version of those libraries, instead of dynamic...Ensures the CLI is linked against dynamic libraries.
Ensures
make cleancleans all the relevant build artifacts.Adds a bunch of comments to
macport.envto make clearer when to set what env var, and for what purpose.Minor refactoring to simplify
Makefile.common.