Skip to content
This repository has been archived by the owner on Oct 24, 2024. It is now read-only.

Commit

Permalink
Taskbar11: Fixed a bug that could crash explorer.exe when right cli…
Browse files Browse the repository at this point in the history
…cking certain system tray icons on 22621-based builds

Impact: Failure to check against a NULL value and dereferencing it
leads to a crash in `explorer.exe` with fault offset 0xfc69 on
22621-based OS builds. This happens when right clicking certain system
tray icons, like "Epic Games Launcher" when using the Windows 11
taskbar.

Description: The issue has been addressed with improved checks: a check
against NULL values is performed before attempting to work with the
data the variables might point to.
  • Loading branch information
valinet committed Nov 12, 2022
1 parent 3717aef commit a6a88b1
Showing 1 changed file with 1 addition and 1 deletion.
2 changes: 1 addition & 1 deletion ExplorerPatcher/dllmain.c
Original file line number Diff line number Diff line change
Expand Up @@ -2235,7 +2235,7 @@ BOOL IsPointOnEmptyAreaOfNewTaskbar(POINT pt)
}
if (SUCCEEDED(hr) && bIsWindows11Version22H2OrHigher)
{
bRet = (!wcscmp(elemName, L"") && !wcscmp(elemType, L"Taskbar.TaskbarFrameAutomationPeer"));
bRet = elemName && elemType && (!wcscmp(elemName, L"") && !wcscmp(elemType, L"Taskbar.TaskbarFrameAutomationPeer"));
}
if (SUCCEEDED(hr) && !bIsWindows11Version22H2OrHigher)
{
Expand Down

0 comments on commit a6a88b1

Please sign in to comment.