Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: upgrade cosmovisor #3575

Merged
merged 1 commit into from
Feb 25, 2025
Merged

chore: upgrade cosmovisor #3575

merged 1 commit into from
Feb 25, 2025

Conversation

gartnera
Copy link
Member

@gartnera gartnera commented Feb 24, 2025

https://github.com/cosmos/cosmos-sdk/releases/tag/cosmovisor%2Fv1.7.1

We already use this version internally: zeta-chain/zetacored-docker#13

Summary by CodeRabbit

  • Chores
    • Upgraded a core dependency to its latest version, enhancing system stability and performance.

@gartnera gartnera added the no-changelog Skip changelog CI check label Feb 24, 2025
@gartnera gartnera requested a review from a team as a code owner February 24, 2025 19:55
@gartnera gartnera enabled auto-merge February 24, 2025 19:56
Copy link
Contributor

coderabbitai bot commented Feb 24, 2025

📝 Walkthrough

Walkthrough

The pull request updates the Dockerfile-localnet by modifying the installation command for the cosmovisor tool, upgrading it from version v1.7.0 to v1.7.1. No other logic, error handling, or public entity declarations are affected.

Changes

File Change Summary
Dockerfile-localnet Updated the cosmovisor installation command from @v1.7.0 to @v1.7.1.

Possibly related PRs

Suggested labels

UPGRADE_TESTS, UPGRADE_LIGHT_TESTS, ci

Suggested reviewers

  • lumtis
  • swift1337
  • kingpinXD
  • fbac

📜 Recent review details

Configuration used: .coderabbit.yaml
Review profile: CHILL
Plan: Pro

📥 Commits

Reviewing files that changed from the base of the PR and between 1288642 and c3e30d3.

📒 Files selected for processing (1)
  • Dockerfile-localnet (1 hunks)
⏰ Context from checks skipped due to timeout of 90000ms (6)
  • GitHub Check: build-zetanode
  • GitHub Check: lint
  • GitHub Check: build-and-test
  • GitHub Check: gosec
  • GitHub Check: build
  • GitHub Check: Analyze (go)
🔇 Additional comments (1)
Dockerfile-localnet (1)

31-31:

✅ Verification successful

LGTM! Verify the version details.

The upgrade to cosmovisor v1.7.1 looks good. Let's verify the version details and any security implications.


🌐 Web query:

What is the latest stable version of cosmovisor? Are there any breaking changes or security fixes in version 1.7.1?

💡 Result:

The latest stable version of cosmovisor is v1.7.1, released on December 20, 20241. This release includes maintenance updates but no documented breaking changes or security-specific fixes23.

Key Details:

  • Installation:

    go install cosmossdk.io/tools/cosmovisor/cmd/cosmovisor@latest
  • Changes in v1.7.x:

    • No Breaking Changes: The release focuses on stability and integration with Cosmos SDK v0.52.x4.
    • Security Context: While no direct vulnerabilities are listed for v1.7.x, earlier versions (<v1.0) had critical security advisories (e.g., denial-of-service risks)5.
    • New Features:
      • Support for Linux kernel’s keyctl backend6.
      • Improved upgrade handling via DAEMON_RESTART_DELAY and UNSAFE_SKIP_BACKUP environment variables7.

Recommendations:

  • Use automated upgrades with DAEMON_RESTART_AFTER_UPGRADE=true for seamless transitions8.
  • Avoid deprecated versions like v0.47.x, which reached end-of-life in December 20249.

For critical chains, test upgrades in a sandbox environment first.

Citations:


LGTM: cosmovisor upgrade verified

The update in Dockerfile-localnet (line 31) upgrades cosmovisor to v1.7.1, which is confirmed as the latest stable release. There are no breaking changes or critical security fixes in this version, and it fits well within our upgrade objectives. Please proceed with merging.


Thank you for using CodeRabbit. We offer it for free to the OSS community and would appreciate your support in helping us grow. If you find it useful, would you consider giving us a shout-out on your favorite social media?

❤️ Share
🪧 Tips

Chat

There are 3 ways to chat with CodeRabbit:

  • Review comments: Directly reply to a review comment made by CodeRabbit. Example:
    • I pushed a fix in commit <commit_id>, please review it.
    • Generate unit testing code for this file.
    • Open a follow-up GitHub issue for this discussion.
  • Files and specific lines of code (under the "Files changed" tab): Tag @coderabbitai in a new review comment at the desired location with your query. Examples:
    • @coderabbitai generate unit testing code for this file.
    • @coderabbitai modularize this function.
  • PR comments: Tag @coderabbitai in a new PR comment to ask questions about the PR branch. For the best results, please provide a very specific query, as very limited context is provided in this mode. Examples:
    • @coderabbitai gather interesting stats about this repository and render them as a table. Additionally, render a pie chart showing the language distribution in the codebase.
    • @coderabbitai read src/utils.ts and generate unit testing code.
    • @coderabbitai read the files in the src/scheduler package and generate a class diagram using mermaid and a README in the markdown format.
    • @coderabbitai help me debug CodeRabbit configuration file.

Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments.

CodeRabbit Commands (Invoked using PR comments)

  • @coderabbitai pause to pause the reviews on a PR.
  • @coderabbitai resume to resume the paused reviews.
  • @coderabbitai review to trigger an incremental review. This is useful when automatic reviews are disabled for the repository.
  • @coderabbitai full review to do a full review from scratch and review all the files again.
  • @coderabbitai summary to regenerate the summary of the PR.
  • @coderabbitai generate docstrings to generate docstrings for this PR. (Beta)
  • @coderabbitai resolve resolve all the CodeRabbit review comments.
  • @coderabbitai configuration to show the current CodeRabbit configuration for the repository.
  • @coderabbitai help to get help.

Other keywords and placeholders

  • Add @coderabbitai ignore anywhere in the PR description to prevent this PR from being reviewed.
  • Add @coderabbitai summary to generate the high-level summary at a specific location in the PR description.
  • Add @coderabbitai anywhere in the PR title to generate the title automatically.

Documentation and Community

  • Visit our Documentation for detailed information on how to use CodeRabbit.
  • Join our Discord Community to get help, request features, and share feedback.
  • Follow us on X/Twitter for updates and announcements.

Footnotes

  1. GitHub: Cosmos SDK v0.50.12 Release Notes

  2. Provenance Blockchain Fork Differences

  3. BitCannaGlobal Security Patch Example

  4. Cosmovisor Upgrade Design

  5. Cosmovisor Security Advisory (Pre-v1)

  6. Linux Kernel Integration

  7. Environment Variables Documentation

  8. Automated Upgrades Guide

  9. End-of-Life Notice for v0.47.x

Copy link

codecov bot commented Feb 24, 2025

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 64.74%. Comparing base (c47032b) to head (c3e30d3).
Report is 4 commits behind head on develop.

Additional details and impacted files

Impacted file tree graph

@@             Coverage Diff             @@
##           develop    #3575      +/-   ##
===========================================
+ Coverage    64.72%   64.74%   +0.02%     
===========================================
  Files          461      462       +1     
  Lines        31894    31960      +66     
===========================================
+ Hits         20644    20694      +50     
- Misses       10345    10358      +13     
- Partials       905      908       +3     

see 5 files with indirect coverage changes

@gartnera gartnera added this pull request to the merge queue Feb 25, 2025
Merged via the queue into develop with commit c427607 Feb 25, 2025
48 of 52 checks passed
@gartnera gartnera deleted the upgrade-cosmovisor-2 branch February 25, 2025 09:15
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
no-changelog Skip changelog CI check
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants