Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

refactor(zetaclient)!: improve AppContext #2568

Merged
merged 28 commits into from
Aug 2, 2024

Address PR comments

0f48ce3
Select commit
Loading
Failed to load commit list.
Merged

refactor(zetaclient)!: improve AppContext #2568

Address PR comments
0f48ce3
Select commit
Loading
Failed to load commit list.
Codecov / codecov/project succeeded Aug 2, 2024 in 1s

70.55% (+0.36%) compared to 65ff18f

View this Pull Request on Codecov

70.55% (+0.36%) compared to 65ff18f

Details

Codecov Report

Attention: Patch coverage is 56.19048% with 230 lines in your changes missing coverage. Please review.

Project coverage is 70.55%. Comparing base (65ff18f) to head (0f48ce3).

Files Patch % Lines
zetaclient/orchestrator/bootstrap.go 48.73% 63 Missing and 18 partials ⚠️
zetaclient/orchestrator/orchestrator.go 52.77% 34 Missing ⚠️
zetaclient/context/app.go 69.90% 25 Missing and 6 partials ⚠️
zetaclient/chains/evm/signer/signer.go 26.47% 24 Missing and 1 partial ⚠️
zetaclient/zetacore/client.go 54.54% 12 Missing and 3 partials ⚠️
zetaclient/context/chain.go 81.57% 14 Missing ⚠️
zetaclient/chains/evm/observer/inbound.go 23.52% 11 Missing and 2 partials ⚠️
zetaclient/zetacore/client_query_observer.go 42.85% 4 Missing ⚠️
zetaclient/chains/evm/signer/outbound_data.go 76.92% 3 Missing ⚠️
x/observer/types/chain_params.go 0.00% 1 Missing and 1 partial ⚠️
... and 7 more
Additional details and impacted files

Impacted file tree graph

@@             Coverage Diff             @@
##           develop    #2568      +/-   ##
===========================================
+ Coverage    70.18%   70.55%   +0.36%     
===========================================
  Files          337      335       -2     
  Lines        18588    18345     -243     
===========================================
- Hits         13046    12943     -103     
+ Misses        4962     4821     -141     
- Partials       580      581       +1
Files Coverage Δ
zetaclient/chains/bitcoin/observer/observer.go 33.22% <ø> (+2.85%) ⬆️
zetaclient/chains/evm/observer/observer.go 58.15% <ø> (+7.19%) ⬆️
zetaclient/config/types.go 42.00% <100.00%> (-1.75%) ⬇️
zetaclient/chains/bitcoin/observer/outbound.go 33.16% <0.00%> (ø)
zetaclient/chains/evm/observer/outbound.go 45.07% <0.00%> (ø)
zetaclient/chains/solana/observer/inbound.go 43.78% <0.00%> (ø)
...taclient/chains/solana/observer/inbound_tracker.go 0.00% <0.00%> (ø)
zetaclient/chains/solana/observer/outbound.go 27.74% <0.00%> (ø)
zetaclient/zetacore/client_worker.go 0.00% <0.00%> (ø)
x/observer/types/chain_params.go 92.85% <0.00%> (-5.74%) ⬇️
... and 10 more

... and 2 files with indirect coverage changes

View more details on Codecov