refactor(pkg/chains): deprecate ChainName field in Chain object
#2541
Conversation
|
Important Review skippedAuto incremental reviews are disabled on this repository. Please check the settings in the CodeRabbit UI or the You can disable this status message by setting the WalkthroughWalkthroughThe recent changes to the Changes
Assessment against linked issues
Thank you for using CodeRabbit. We offer it for free to the OSS community and would appreciate your support in helping us grow. If you find it useful, would you consider giving us a shout-out on your favorite social media? TipsChatThere are 3 ways to chat with CodeRabbit:
Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments. CodeRabbit Commands (invoked as PR comments)
Additionally, you can add CodeRabbit Configuration File (
|
lumtis
added
UPGRADE_TESTS
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## develop #2541 +/- ##
===========================================
- Coverage 46.65% 46.63% -0.03%
===========================================
Files 464 464
Lines 30834 30843 +9
===========================================
- Hits 14385 14383 -2
- Misses 15595 15604 +9
- Partials 854 856 +2
|
lumtis
requested review from
brewmaster012,
kingpinXD,
ws4charlie,
skosito,
swift1337 and
fbac
as code owners
![coderabbitai[bot]](https://avatars.githubusercontent.com/in/347564?s=60&v=4){kind=small}
There was a problem hiding this comment.
Actionable comments posted: 7
Outside diff range, codebase verification and nitpick comments (3)
zetaclient/chains/bitcoin/signer/signer.go (3)
444-444: Add test coverage for this log statement.The log statement referencing
chain.Namein theTryProcessOutboundfunction of the Bitcoin signer is not covered by tests. Ensure this scenario is tested to maintain comprehensive test coverage.
- File:
zetaclient/chains/bitcoin/signer/signer.go- Function:
TryProcessOutboundAnalysis chain
Add test coverage for this log statement.
The log statement referencing
chain.Nameis not covered by tests. Ensure this scenario is tested to maintain comprehensive test coverage.Scripts executed
The following scripts were executed for the analysis:
Script:
#!/bin/bash # Description: Verify test coverage for the log statement. # Test: Search for test cases covering `TryProcessOutbound` function. Expect: Test cases covering the log statement. rg --type go -A 10 'TryProcessOutbound'Length of output: 11166
Script:
#!/bin/bash # Description: Verify test coverage for the TryProcessOutbound function in the Bitcoin signer. # Test: Search for test cases covering the TryProcessOutbound function in the Bitcoin signer. rg --type go -A 10 'TryProcessOutbound' | rg 'zetaclient/chains/bitcoin/signer/signer.go'Length of output: 3556
Tools
GitHub Check: codecov/patch
[warning] 444-444: zetaclient/chains/bitcoin/signer/signer.go#L444
Added line #L444 was not covered by tests
432-432: Add test coverage for the Bitcoin signer'sTryProcessOutboundfunction.The log statement referencing
chain.Namein theTryProcessOutboundfunction of the Bitcoin signer is not covered by tests. Ensure this scenario is tested to maintain comprehensive test coverage.
- File:
zetaclient/chains/bitcoin/signer/signer.go- Line: 432
Analysis chain
Add test coverage for this log statement.
The log statement referencing
chain.Nameis not covered by tests. Ensure this scenario is tested to maintain comprehensive test coverage.Scripts executed
The following scripts were executed for the analysis:
Script:
#!/bin/bash # Description: Verify test coverage for the log statement. # Test: Search for test cases covering `TryProcessOutbound` function. Expect: Test cases covering the log statement. rg --type go -A 10 'TryProcessOutbound'Length of output: 11166
Script:
#!/bin/bash # Description: Verify test coverage for the log statement in Bitcoin signer. # Test: Search for test files related to Bitcoin signer. fd --type f --name '*signer_test.go' | grep 'bitcoin'Length of output: 304
Script:
#!/bin/bash # Description: Verify test coverage for the log statement in Bitcoin signer. # Test: Search for test files related to Bitcoin signer. fd --type f --glob '*bitcoin*signer_test.go'Length of output: 46
Script:
#!/bin/bash # Description: Verify test coverage for the log statement in Bitcoin signer. # Test: Search for references to the Bitcoin signer's TryProcessOutbound function in test files. rg --type go 'TryProcessOutbound' --glob '*_test.go'Length of output: 277
Tools
GitHub Check: codecov/patch
[warning] 432-432: zetaclient/chains/bitcoin/signer/signer.go#L432
Added line #L432 was not covered by tests
471-471: Add test coverage for the log statement.The log statement referencing
chain.Namein theTryProcessOutboundfunction withinzetaclient/chains/bitcoin/signer/signer.gois not covered by any tests. Ensure this scenario is tested to maintain comprehensive test coverage.
- File:
zetaclient/chains/bitcoin/signer/signer.go- Line: 471
- Log Statement:
Msgf("Unable to add to tracker on zetacore: nonce %d chain %s outboundHash %s", outboundTssNonce, chain.Name, outboundHash)Please add appropriate test cases to cover this log statement.
Analysis chain
Add test coverage for this log statement.
The log statement referencing
chain.Nameis not covered by tests. Ensure this scenario is tested to maintain comprehensive test coverage.Scripts executed
The following scripts were executed for the analysis:
Script:
#!/bin/bash # Description: Verify test coverage for the log statement. # Test: Search for test cases covering `TryProcessOutbound` function. Expect: Test cases covering the log statement. rg --type go -A 10 'TryProcessOutbound'Length of output: 11166
Script:
#!/bin/bash # Search for test files related to the Bitcoin signer fd --type f --name '*signer_test.go' | xargs rg --type go -A 10 'chain.Name'Length of output: 15995
Script:
#!/bin/bash # Search for test files specifically in the zetaclient/chains/bitcoin/signer directory fd --type f --name '*_test.go' zetaclient/chains/bitcoin/signer | xargs rg --type go 'TryProcessOutbound'Length of output: 2139
Script:
#!/bin/bash # Corrected script to search for test files specifically in the zetaclient/chains/bitcoin/signer directory fd . --type f -e go | grep 'signer_test.go' | xargs rg --type go 'TryProcessOutbound'Length of output: 308
Tools
GitHub Check: codecov/patch
[warning] 471-471: zetaclient/chains/bitcoin/signer/signer.go#L471
Added line #L471 was not covered by tests
Review details
Configuration used: .coderabbit.yaml
Review profile: CHILL
Files ignored due to path filters (2)
pkg/chains/chains.pb.gois excluded by!**/*.pb.go,!**/*.pb.gotypescript/zetachain/zetacore/pkg/chains/chains_pb.d.tsis excluded by!**/*_pb.d.ts
Files selected for processing (32)
- changelog.md (1 hunks)
- docs/openapi/openapi.swagger.yaml (3 hunks)
- docs/releases/v19_breaking_changes.md (2 hunks)
- docs/releases/v19_observer_migration.md (1 hunks)
- pkg/chains/chain.go (3 hunks)
- pkg/chains/chain_test.go (8 hunks)
- pkg/chains/chains.go (23 hunks)
- pkg/chains/chains_test.go (1 hunks)
- proto/zetachain/zetacore/pkg/chains/chains.proto (3 hunks)
- testutil/keeper/crosschain.go (2 hunks)
- testutil/sample/sample.go (1 hunks)
- testutil/testdata/types/chain_info.json (1 hunks)
- x/authority/client/cli/tx_update_chain_info_test.go (1 hunks)
- x/authority/types/chain_info_test.go (2 hunks)
- x/authority/types/genesis_test.go (1 hunks)
- x/authority/types/message_update_chain_info_test.go (1 hunks)
- x/crosschain/keeper/cctx_utils.go (2 hunks)
- x/crosschain/keeper/cctx_utils_test.go (5 hunks)
- x/crosschain/keeper/msg_server_update_tss_test.go (6 hunks)
- x/crosschain/migrations/v5/migrate.go (1 hunks)
- x/fungible/keeper/grpc_query_gas_stability_pool_test.go (2 hunks)
- zetaclient/chains/base/observer.go (1 hunks)
- zetaclient/chains/bitcoin/observer/inbound.go (1 hunks)
- zetaclient/chains/bitcoin/signer/signer.go (4 hunks)
- zetaclient/chains/evm/observer/inbound.go (3 hunks)
- zetaclient/context/app.go (1 hunks)
- zetaclient/context/app_test.go (3 hunks)
- zetaclient/metrics/telemetry.go (1 hunks)
- zetaclient/orchestrator/bootstrap.go (5 hunks)
- zetaclient/orchestrator/orchestrator.go (1 hunks)
- zetaclient/zetacore/client_query_test.go (1 hunks)
- zetaclient/zetacore/tx_test.go (1 hunks)
Files skipped from review due to trivial changes (9)
- docs/releases/v19_observer_migration.md
- testutil/keeper/crosschain.go
- x/crosschain/keeper/cctx_utils.go
- x/crosschain/keeper/cctx_utils_test.go
- x/crosschain/keeper/msg_server_update_tss_test.go
- x/crosschain/migrations/v5/migrate.go
- x/fungible/keeper/grpc_query_gas_stability_pool_test.go
- zetaclient/chains/base/observer.go
- zetaclient/context/app_test.go
Additional context used
Path-based instructions (19)
x/authority/client/cli/tx_update_chain_info_test.go (1)
Pattern
**/*.go: Review the Go code, point out issues relative to principles of clean code, expressiveness, and performance.x/authority/types/genesis_test.go (1)
Pattern
**/*.go: Review the Go code, point out issues relative to principles of clean code, expressiveness, and performance.x/authority/types/chain_info_test.go (1)
Pattern
**/*.go: Review the Go code, point out issues relative to principles of clean code, expressiveness, and performance.x/authority/types/message_update_chain_info_test.go (1)
Pattern
**/*.go: Review the Go code, point out issues relative to principles of clean code, expressiveness, and performance.proto/zetachain/zetacore/pkg/chains/chains.proto (1)
Pattern
**/*.proto: Review the Protobuf definitions, point out issues relative to compatibility, and expressiveness.pkg/chains/chain.go (1)
Pattern
**/*.go: Review the Go code, point out issues relative to principles of clean code, expressiveness, and performance.zetaclient/metrics/telemetry.go (1)
Pattern
**/*.go: Review the Go code, point out issues relative to principles of clean code, expressiveness, and performance.pkg/chains/chains_test.go (1)
Pattern
**/*.go: Review the Go code, point out issues relative to principles of clean code, expressiveness, and performance.zetaclient/context/app.go (1)
Pattern
**/*.go: Review the Go code, point out issues relative to principles of clean code, expressiveness, and performance.zetaclient/orchestrator/bootstrap.go (1)
Pattern
**/*.go: Review the Go code, point out issues relative to principles of clean code, expressiveness, and performance.pkg/chains/chain_test.go (1)
Pattern
**/*.go: Review the Go code, point out issues relative to principles of clean code, expressiveness, and performance.pkg/chains/chains.go (1)
Pattern
**/*.go: Review the Go code, point out issues relative to principles of clean code, expressiveness, and performance.zetaclient/chains/bitcoin/signer/signer.go (1)
Pattern
**/*.go: Review the Go code, point out issues relative to principles of clean code, expressiveness, and performance.zetaclient/chains/bitcoin/observer/inbound.go (1)
Pattern
**/*.go: Review the Go code, point out issues relative to principles of clean code, expressiveness, and performance.zetaclient/zetacore/tx_test.go (1)
Pattern
**/*.go: Review the Go code, point out issues relative to principles of clean code, expressiveness, and performance.zetaclient/orchestrator/orchestrator.go (1)
Pattern
**/*.go: Review the Go code, point out issues relative to principles of clean code, expressiveness, and performance.testutil/sample/sample.go (1)
Pattern
**/*.go: Review the Go code, point out issues relative to principles of clean code, expressiveness, and performance.zetaclient/chains/evm/observer/inbound.go (1)
Pattern
**/*.go: Review the Go code, point out issues relative to principles of clean code, expressiveness, and performance.zetaclient/zetacore/client_query_test.go (1)
Pattern
**/*.go: Review the Go code, point out issues relative to principles of clean code, expressiveness, and performance.
GitHub Check: codecov/patch
zetaclient/metrics/telemetry.go
[warning] 92-92: zetaclient/metrics/telemetry.go#L92
Added line #L92 was not covered by testszetaclient/context/app.go
[warning] 339-339: zetaclient/context/app.go#L339
Added line #L339 was not covered by testszetaclient/orchestrator/bootstrap.go
[warning] 235-236: zetaclient/orchestrator/bootstrap.go#L235-L236
Added lines #L235 - L236 were not covered by tests
[warning] 265-265: zetaclient/orchestrator/bootstrap.go#L265
Added line #L265 was not covered by tests
[warning] 360-361: zetaclient/orchestrator/bootstrap.go#L360-L361
Added lines #L360 - L361 were not covered by tests
[warning] 390-390: zetaclient/orchestrator/bootstrap.go#L390
Added line #L390 was not covered by testszetaclient/chains/bitcoin/signer/signer.go
[warning] 432-432: zetaclient/chains/bitcoin/signer/signer.go#L432
Added line #L432 was not covered by tests
[warning] 444-444: zetaclient/chains/bitcoin/signer/signer.go#L444
Added line #L444 was not covered by tests
[warning] 454-454: zetaclient/chains/bitcoin/signer/signer.go#L454
Added line #L454 was not covered by tests
[warning] 471-471: zetaclient/chains/bitcoin/signer/signer.go#L471
Added line #L471 was not covered by testszetaclient/chains/bitcoin/observer/inbound.go
[warning] 242-242: zetaclient/chains/bitcoin/observer/inbound.go#L242
Added line #L242 was not covered by testszetaclient/orchestrator/orchestrator.go
[warning] 353-353: zetaclient/orchestrator/orchestrator.go#L353
Added line #L353 was not covered by testszetaclient/chains/evm/observer/inbound.go
[warning] 185-185: zetaclient/chains/evm/observer/inbound.go#L185
Added line #L185 was not covered by tests
[warning] 295-295: zetaclient/chains/evm/observer/inbound.go#L295
Added line #L295 was not covered by tests
[warning] 376-376: zetaclient/chains/evm/observer/inbound.go#L376
Added line #L376 was not covered by tests
Additional comments not posted (59)
docs/openapi/openapi.swagger.yaml (2)
Line range hint
10-10:
Deprecation Notice forchain_name.The deprecation notice for
chain_nameis clear and correctly indicates that it has been replaced byname.
Line range hint
11-11:
Addition ofnameField.The new
namefield is correctly defined as a string and provides a clear description.testutil/testdata/types/chain_info.json (2)
10-11: Addition ofnameField for Chain ID 42.The
namefield for the chain withchain_id42 is correctly added and provides a descriptive name "foo".
20-21: Addition ofnameField for Chain ID 84.The
namefield for the chain withchain_id84 is correctly added and provides a descriptive name "bar".x/authority/client/cli/tx_update_chain_info_test.go (2)
28-28: Update Test Case for Chain ID 42.The test case for the chain with
chain_id42 correctly reflects the updated structure with theNamefield.
38-38: Update Test Case for Chain ID 84.The test case for the chain with
chain_id84 correctly reflects the updated structure with theNamefield.x/authority/types/genesis_test.go (1)
62-62: Ensure consistency with the newNamefield.The change from
ChainNametoNameappears correct. Ensure that all references toChainNameare updated throughout the codebase to maintain consistency.x/authority/types/chain_info_test.go (2)
45-45: Ensure consistency with the newNamefield.The change from
ChainNametoNameappears correct. Ensure that all references toChainNameare updated throughout the codebase to maintain consistency.
62-62: Ensure consistency with the newNamefield.The change from
ChainNametoNameappears correct. Ensure that all references toChainNameare updated throughout the codebase to maintain consistency.x/authority/types/message_update_chain_info_test.go (1)
40-40: Ensure consistency with the newNamefield.The change from
ChainNametoNameappears correct. Ensure that all references toChainNameare updated throughout the codebase to maintain consistency.proto/zetachain/zetacore/pkg/chains/chains.proto (2)
21-21: Deprecation annotation is appropriate.The deprecation of the
ChainNameenum is correctly annotated, guiding users to transition to the newnamefield.
119-120: Deprecation annotation and new field addition are appropriate.The deprecation of the
chain_namefield and the addition of thenamefield in theChainmessage are correctly implemented. This aligns with the objective of simplifying theChainobject.Also applies to: 140-141
docs/releases/v19_breaking_changes.md (3)
2-2: Versioning header update is appropriate.The header update from "V17 Breaking Changes" to "V19 Breaking Changes" accurately reflects the new version.
65-65: Renaming enhances consistency.The renaming of
MsgAddBlameVotetoMsgVoteBlamealigns with the naming conventions of other voting-related messages, enhancing consistency.
66-68: Deprecation notice is clear and appropriate.The deprecation notice for
Chain.ChainNameis clear and guides developers to transition to theChain.Namefield.pkg/chains/chain.go (1)
35-37: Validation changes are appropriate.The removal of the
ChainNameenum check and the addition of a check for theNamefield in theValidatemethod are appropriate. These changes enhance validation robustness.pkg/chains/chains_test.go (1)
11-17: Good addition!The new test function
TestChain_Nameeffectively ensures the consistency between theNamefield and theChainNameenum.zetaclient/orchestrator/bootstrap.go (4)
231-237: Ensure proper error handling for missing chain information.The introduction of
chains.GetChainFromChainIDimproves robustness by checking for valid chain data. Ensure that this pattern is consistently applied across the codebase to prevent potential runtime errors.Tools
GitHub Check: codecov/patch
[warning] 235-236: zetaclient/orchestrator/bootstrap.go#L235-L236
Added lines #L235 - L236 were not covered by tests
355-362: Ensure proper error handling for missing chain information.The introduction of
chains.GetChainFromChainIDimproves robustness by checking for valid chain data. Ensure that this pattern is consistently applied across the codebase to prevent potential runtime errors.Tools
GitHub Check: codecov/patch
[warning] 360-361: zetaclient/orchestrator/bootstrap.go#L360-L361
Added lines #L360 - L361 were not covered by tests
388-390: Add test coverage for database initialization errors.The error handling for database initialization is crucial. Ensure this scenario is covered by tests to maintain robustness.
Tools
GitHub Check: codecov/patch
[warning] 390-390: zetaclient/orchestrator/bootstrap.go#L390
Added line #L390 was not covered by tests
263-265: Add test coverage for database initialization errors.The error handling for database initialization is crucial. Ensure this scenario is covered by tests to maintain robustness.
Tools
GitHub Check: codecov/patch
[warning] 265-265: zetaclient/orchestrator/bootstrap.go#L265
Added line #L265 was not covered by testspkg/chains/chain_test.go (9)
24-24: Ensure consistency in naming conventions.The replacement of
ChainNamewith a direct string assignment to theNamefield simplifies the structure. Ensure this pattern is consistently applied across all test cases.
36-36: Ensure consistency in naming conventions.The replacement of
ChainNamewith a direct string assignment to theNamefield simplifies the structure. Ensure this pattern is consistently applied across all test cases.
49-49: Ensure consistency in naming conventions.The replacement of
ChainNamewith a direct string assignment to theNamefield simplifies the structure. Ensure this pattern is consistently applied across all test cases.
59-62: Clarify error messages for better readability.The updated error message specifies that the error occurs when the chain name is empty, enhancing the specificity and readability of the test outputs.
75-75: Ensure consistency in naming conventions.The replacement of
ChainNamewith a direct string assignment to theNamefield simplifies the structure. Ensure this pattern is consistently applied across all test cases.
88-88: Ensure consistency in naming conventions.The replacement of
ChainNamewith a direct string assignment to theNamefield simplifies the structure. Ensure this pattern is consistently applied across all test cases.
101-101: Ensure consistency in naming conventions.The replacement of
ChainNamewith a direct string assignment to theNamefield simplifies the structure. Ensure this pattern is consistently applied across all test cases.
114-114: Ensure consistency in naming conventions.The replacement of
ChainNamewith a direct string assignment to theNamefield simplifies the structure. Ensure this pattern is consistently applied across all test cases.
194-194: Ensure consistency in naming conventions.The replacement of
ChainNamewith a direct string assignment to theNamefield simplifies the structure. Ensure this pattern is consistently applied across all test cases.pkg/chains/chains.go (17)
20-20: LGTM! Ensure consistency in naming conventions.The addition of the
Namefield to theZetaChainMainnetconfiguration enhances clarity. Ensure this pattern is consistently applied across all network configurations.
33-33: LGTM! Ensure consistency in naming conventions.The addition of the
Namefield to theEthereumconfiguration enhances clarity. Ensure this pattern is consistently applied across all network configurations.
46-46: LGTM! Ensure consistency in naming conventions.The addition of the
Namefield to theBscMainnetconfiguration enhances clarity. Ensure this pattern is consistently applied across all network configurations.
59-59: LGTM! Ensure consistency in naming conventions.The addition of the
Namefield to theBitcoinMainnetconfiguration enhances clarity. Ensure this pattern is consistently applied across all network configurations.
72-72: LGTM! Ensure consistency in naming conventions.The addition of the
Namefield to thePolygonconfiguration enhances clarity. Ensure this pattern is consistently applied across all network configurations.
85-85: LGTM! Ensure consistency in naming conventions.The addition of the
Namefield to theOptimismMainnetconfiguration enhances clarity. Ensure this pattern is consistently applied across all network configurations.
98-98: LGTM! Ensure consistency in naming conventions.The addition of the
Namefield to theBaseMainnetconfiguration enhances clarity. Ensure this pattern is consistently applied across all network configurations.
113-113: LGTM! Ensure consistency in naming conventions.The addition of the
Namefield to theSolanaMainnetconfiguration enhances clarity. Ensure this pattern is consistently applied across all network configurations.
130-130: LGTM! Ensure consistency in naming conventions.The addition of the
Namefield to theZetaChainTestnetconfiguration enhances clarity. Ensure this pattern is consistently applied across all network configurations.
143-143: LGTM! Ensure consistency in naming conventions.The addition of the
Namefield to theSepoliaconfiguration enhances clarity. Ensure this pattern is consistently applied across all network configurations.
156-156: LGTM! Ensure consistency in naming conventions.The addition of the
Namefield to theBscTestnetconfiguration enhances clarity. Ensure this pattern is consistently applied across all network configurations.
169-169: LGTM! Ensure consistency in naming conventions.The addition of the
Namefield to theBitcoinTestnetconfiguration enhances clarity. Ensure this pattern is consistently applied across all network configurations.
182-182: LGTM! Ensure consistency in naming conventions.The addition of the
Namefield to theAmoyconfiguration enhances clarity. Ensure this pattern is consistently applied across all network configurations.
195-195: LGTM! Ensure consistency in naming conventions.The addition of the
Namefield to theOptimismSepoliaconfiguration enhances clarity. Ensure this pattern is consistently applied across all network configurations.
208-208: LGTM! Ensure consistency in naming conventions.The addition of the
Namefield to theBaseSepoliaconfiguration enhances clarity. Ensure this pattern is consistently applied across all network configurations.
225-225: LGTM! Ensure consistency in naming conventions.The addition of the
Namefield to theSolanaDevnetconfiguration enhances clarity. Ensure this pattern is consistently applied across all network configurations.
243-243: LGTM! Ensure consistency in naming conventions.The addition of the
Namefield to theZetaChainDevnetconfiguration enhances clarity. Ensure this pattern is consistently applied across all network configurations.zetaclient/chains/bitcoin/signer/signer.go (1)
454-454: Add test coverage for this log statement.The log statement referencing
chain.Nameis not covered by tests. Ensure this scenario is tested to maintain comprehensive test coverage.Tools
GitHub Check: codecov/patch
[warning] 454-454: zetaclient/chains/bitcoin/signer/signer.go#L454
Added line #L454 was not covered by testszetaclient/chains/bitcoin/observer/inbound.go (1)
242-242: Add test coverage for this log statement.The log statement referencing
ob.Chain().Nameis not covered by tests. Ensure this scenario is tested to maintain comprehensive test coverage.Tools
GitHub Check: codecov/patch
[warning] 242-242: zetaclient/chains/bitcoin/observer/inbound.go#L242
Added line #L242 was not covered by testszetaclient/zetacore/tx_test.go (2)
287-294: Initialization of Chain objects is clear and correct.The use of named field initialization enhances readability and maintainability.
297-304: Initialization of Chain objects is clear and correct.The use of named field initialization enhances readability and maintainability.
zetaclient/orchestrator/orchestrator.go (1)
353-353: Verify the function usage in the codebase.The code changes are approved.
However, ensure that all function calls to
c.Namematch the new field and are correctly updated throughout the codebase.Tools
GitHub Check: codecov/patch
[warning] 353-353: zetaclient/orchestrator/orchestrator.go#L353
Added line #L353 was not covered by teststestutil/sample/sample.go (1)
136-136: Verify the function usage in the codebase.The code changes are approved.
However, ensure that all function calls to
Chainmatch the new field and are correctly updated throughout the codebase.zetaclient/chains/evm/observer/inbound.go (3)
295-295: Verify the function usage in the codebase.The code changes are approved.
However, ensure that all function calls to
ob.Chain().Namematch the new field and are correctly updated throughout the codebase.Tools
GitHub Check: codecov/patch
[warning] 295-295: zetaclient/chains/evm/observer/inbound.go#L295
Added line #L295 was not covered by tests
185-185: Verify the function usage in the codebase.The code changes are approved.
However, ensure that all function calls to
ob.Chain().Namematch the new field and are correctly updated throughout the codebase.Tools
GitHub Check: codecov/patch
[warning] 185-185: zetaclient/chains/evm/observer/inbound.go#L185
Added line #L185 was not covered by tests
376-376: Verify the function usage in the codebase.The code changes are approved.
However, ensure that all function calls to
ob.Chain().Namematch the new field and are correctly updated throughout the codebase.Tools
GitHub Check: codecov/patch
[warning] 376-376: zetaclient/chains/evm/observer/inbound.go#L376
Added line #L376 was not covered by testszetaclient/zetacore/client_query_test.go (2)
875-875: Update test expectations to match new schema.The change correctly updates the expected output to replace
ChainNamewithName.
884-884: Update test expectations to match new schema.The change correctly updates the expected output to replace
ChainNamewithName.changelog.md (1)
67-67: Changelog entry correctly documents the deprecation.The entry accurately reflects the changes made in the PR.
github-merge-queue
bot
removed this pull request from the merge queue due to failed status checks
Description
Closes: #1407
ChainNamewith a stringNamedefining the name of the chainRelated: #2005 -- will allow adding new chain info entirely dynamically
Summary by CodeRabbit
New Features
Namefield for blockchain configurations, enhancing clarity and usability.ChainNamefield in favor ofName.Bug Fixes
Name.Documentation
ChainNamedeprecation and new naming conventions.Tests
Namefield and updated existing tests to ensure consistency with new structures.Chores
ChainNameacross various code files for better code quality and consistency.