Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: add Polygon, Base and Base Sepolia in static chain info #2470

Merged
merged 7 commits into from
Jul 12, 2024
Merged

feat: add Polygon, Base and Base Sepolia in static chain info #2470

merged 7 commits into from
Jul 12, 2024

Conversation

lumtis
Copy link
Member

@lumtis lumtis commented Jul 12, 2024 •
edited by gartnera
Loading

Description

As part of v18

upgrade tests pass

@coderabbitai coderabbitai
Copy link
Contributor

coderabbitai bot commented Jul 12, 2024 •
edited
Loading

Important

Review skipped

Auto reviews are disabled on base/target branches other than the default branch.

Please check the settings in the CodeRabbit UI or the .coderabbit.yaml file in this repository. To trigger a single review, invoke the @coderabbitai review command.

You can disable this status message by setting the reviews.review_status to false in the CodeRabbit configuration file.

Thank you for using CodeRabbit. We offer it for free to the OSS community and would appreciate your support in helping us grow. If you find it useful, would you consider giving us a shout-out on your favorite social media?

Share
Tips

Chat

There are 3 ways to chat with CodeRabbit:

  • Review comments: Directly reply to a review comment made by CodeRabbit. Example:
    • I pushed a fix in commit <commit_id>.
    • Generate unit testing code for this file.
    • Open a follow-up GitHub issue for this discussion.
  • Files and specific lines of code (under the "Files changed" tab): Tag @coderabbitai in a new review comment at the desired location with your query. Examples:
    • @coderabbitai generate unit testing code for this file.
    • @coderabbitai modularize this function.
  • PR comments: Tag @coderabbitai in a new PR comment to ask questions about the PR branch. For the best results, please provide a very specific query, as very limited context is provided in this mode. Examples:
    • @coderabbitai generate interesting stats about this repository and render them as a table.
    • @coderabbitai show all the console.log statements in this repository.
    • @coderabbitai read src/utils.ts and generate unit testing code.
    • @coderabbitai read the files in the src/scheduler package and generate a class diagram using mermaid and a README in the markdown format.
    • @coderabbitai help me debug CodeRabbit configuration file.

Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments.

CodeRabbit Commands (invoked as PR comments)

  • @coderabbitai pause to pause the reviews on a PR.
  • @coderabbitai resume to resume the paused reviews.
  • @coderabbitai review to trigger an incremental review. This is useful when automatic reviews are disabled for the repository.
  • @coderabbitai full review to do a full review from scratch and review all the files again.
  • @coderabbitai summary to regenerate the summary of the PR.
  • @coderabbitai resolve resolve all the CodeRabbit review comments.
  • @coderabbitai configuration to show the current CodeRabbit configuration for the repository.
  • @coderabbitai help to get help.

Additionally, you can add @coderabbitai ignore anywhere in the PR description to prevent this PR from being reviewed.

CodeRabbit Configration File (.coderabbit.yaml)

  • You can programmatically configure CodeRabbit by adding a .coderabbit.yaml file to the root of your repository.
  • Please see the configuration documentation for more information.
  • If your editor has YAML language server enabled, you can add the path at the top of this file to enable auto-completion and validation: # yaml-language-server: $schema=https://coderabbit.ai/integrations/schema.v2.json

Documentation and Community

  • Visit our Documentation for detailed information on how to use CodeRabbit.
  • Join our Discord Community to get help, request features, and share feedback.
  • Follow us on X/Twitter for updates and announcements.

@lumtis lumtis marked this pull request as ready for review July 12, 2024 15:26
@lumtis lumtis requested a review from gartnera July 12, 2024 15:45
swift1337
swift1337 reviewed Jul 12, 2024
View reviewed changes
docs/openapi/openapi.swagger.yaml
@@ -53612,6 +53612,10 @@ definitions:
- goerli_localnet
- btc_regtest
- amoy_testnet
- optimism_mainnet
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Are OP stack keys placed on purpose?

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

To keep consistency with the field numbers on develop although these values are not used here

@lumtis lumtis requested review from gartnera and swift1337 July 12, 2024 16:06
@lumtis
Copy link
Member Author

lumtis commented Jul 12, 2024

Upgrade test successful completion: https://github.com/zeta-chain/node/actions/runs/9910599831/job/27381349189

brewmaster012
brewmaster012 reviewed Jul 12, 2024
View reviewed changes
pkg/chains/chain.go
chainID == SepoliaChain().ChainId || // Sepolia
chainID == PolygonChain().ChainId ||
chainID == SepoliaChain().ChainId ||
chainID == BaseMainnetChain().ChainId ||
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

should we add optimism chains here

brewmaster012
brewmaster012 approved these changes Jul 12, 2024
View reviewed changes
Copy link
Collaborator

@brewmaster012 brewmaster012 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@lumtis lumtis merged commit 0fa54ed into release/v18 Jul 12, 2024
21 checks passed
@lumtis lumtis deleted the polygon-base-static-chain-info branch July 12, 2024 19:00
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@gartnera gartnera gartnera approved these changes

@kingpinXD kingpinXD kingpinXD approved these changes

@CharlieMc0 CharlieMc0 CharlieMc0 approved these changes

@ws4charlie ws4charlie ws4charlie approved these changes

@brewmaster012 brewmaster012 brewmaster012 approved these changes

@skosito skosito Awaiting requested review from skosito skosito is a code owner

@swift1337 swift1337 Awaiting requested review from swift1337

Assignees
No one assigned
Labels
breaking:proto
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
7 participants
@lumtis @gartnera @swift1337 @kingpinXD @CharlieMc0 @ws4charlie @brewmaster012