Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ci: enable artifact attenstations #2388

Merged
merged 30 commits into from
Jun 27, 2024

Conversation

CharlieMc0
Copy link
Member

Description

Enables GitHub attestations to verify the binaries available on our releases page were built by our CI.

More info about GitHub attestations here

Attestations will be available to view https://github.com/zeta-chain/node/attestations, as a JSON file attached to the releases page, and at https://search.sigstore.dev/.

Closes:

Type of change

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • This change requires a documentation update

How Has This Been Tested?

Please describe the tests that you ran to verify your changes. Include instructions and any relevant details so others can reproduce.

  • Tested CCTX in localnet
  • Tested in development environment
  • Go unit tests
  • Go integration tests
  • Tested via GitHub Actions

Checklist:

  • I have added unit tests that prove my fix feature works

Copy link
Contributor

coderabbitai bot commented Jun 26, 2024

Important

Review skipped

Review was skipped due to path filters

Files ignored due to path filters (4)
  • .github/workflows/docker-build-and-push.yml is excluded by none and included by none
  • .github/workflows/publish-release.yml is excluded by none and included by none
  • .goreleaser.yaml is excluded by none and included by none
  • changelog.md is excluded by none and included by none

You can disable this status message by setting the reviews.review_status to false in the CodeRabbit configuration file.


Thank you for using CodeRabbit. We offer it for free to the OSS community and would appreciate your support in helping us grow. If you find it useful, would you consider giving us a shout-out on your favorite social media?

Share
Tips

Chat

There are 3 ways to chat with CodeRabbit:

  • Review comments: Directly reply to a review comment made by CodeRabbit. Example:
    • I pushed a fix in commit <commit_id>.
    • Generate unit testing code for this file.
    • Open a follow-up GitHub issue for this discussion.
  • Files and specific lines of code (under the "Files changed" tab): Tag @coderabbitai in a new review comment at the desired location with your query. Examples:
    • @coderabbitai generate unit testing code for this file.
    • @coderabbitai modularize this function.
  • PR comments: Tag @coderabbitai in a new PR comment to ask questions about the PR branch. For the best results, please provide a very specific query, as very limited context is provided in this mode. Examples:
    • @coderabbitai generate interesting stats about this repository and render them as a table.
    • @coderabbitai show all the console.log statements in this repository.
    • @coderabbitai read src/utils.ts and generate unit testing code.
    • @coderabbitai read the files in the src/scheduler package and generate a class diagram using mermaid and a README in the markdown format.
    • @coderabbitai help me debug CodeRabbit configuration file.

Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments.

CodeRabbit Commands (invoked as PR comments)

  • @coderabbitai pause to pause the reviews on a PR.
  • @coderabbitai resume to resume the paused reviews.
  • @coderabbitai review to trigger an incremental review. This is useful when automatic reviews are disabled for the repository.
  • @coderabbitai full review to do a full review from scratch and review all the files again.
  • @coderabbitai summary to regenerate the summary of the PR.
  • @coderabbitai resolve resolve all the CodeRabbit review comments.
  • @coderabbitai configuration to show the current CodeRabbit configuration for the repository.
  • @coderabbitai help to get help.

Additionally, you can add @coderabbitai ignore anywhere in the PR description to prevent this PR from being reviewed.

CodeRabbit Configration File (.coderabbit.yaml)

  • You can programmatically configure CodeRabbit by adding a .coderabbit.yaml file to the root of your repository.
  • Please see the configuration documentation for more information.
  • If your editor has YAML language server enabled, you can add the path at the top of this file to enable auto-completion and validation: # yaml-language-server: $schema=https://coderabbit.ai/integrations/schema.v2.json

Documentation and Community

  • Visit our Documentation for detailed information on how to use CodeRabbit.
  • Join our Discord Community to get help, request features, and share feedback.
  • Follow us on X/Twitter for updates and announcements.

@github-actions github-actions bot added the ci Changes to CI pipeline or github actions label Jun 26, 2024
Copy link

gitguardian bot commented Jun 26, 2024

⚠️ GitGuardian has uncovered 19 secrets following the scan of your pull request.

Please consider investigating the findings and remediating the incidents. Failure to do so may lead to compromising the associated services or software components.

🔎 Detected hardcoded secrets in your pull request
GitGuardian id GitGuardian status Secret Commit Filename
10046624 Ignored Generic High Entropy Secret 77e83a3 cmd/zetae2e/local/accounts.go View secret
10046624 Ignored Generic High Entropy Secret 77e83a3 cmd/zetae2e/config/localnet.yml View secret
10046625 Ignored Generic High Entropy Secret 77e83a3 cmd/zetae2e/config/localnet.yml View secret
10046625 Ignored Generic High Entropy Secret 77e83a3 cmd/zetae2e/local/accounts.go View secret
11033143 Triggered Generic High Entropy Secret 77e83a3 cmd/zetae2e/local/accounts.go View secret
11033143 Triggered Generic High Entropy Secret 77e83a3 cmd/zetae2e/config/local.yml View secret
11033143 Triggered Generic High Entropy Secret 77e83a3 cmd/zetae2e/config/localnet.yml View secret
11033144 Triggered Generic High Entropy Secret 77e83a3 cmd/zetae2e/config/localnet.yml View secret
11033144 Triggered Generic High Entropy Secret 77e83a3 cmd/zetae2e/local/accounts.go View secret
11033145 Triggered Generic High Entropy Secret 77e83a3 cmd/zetae2e/local/accounts.go View secret
11033145 Triggered Generic High Entropy Secret 77e83a3 cmd/zetae2e/config/localnet.yml View secret
11033146 Triggered Generic High Entropy Secret 77e83a3 cmd/zetae2e/local/accounts.go View secret
11033146 Triggered Generic High Entropy Secret 77e83a3 cmd/zetae2e/config/localnet.yml View secret
11478175 Triggered Generic High Entropy Secret 77e83a3 cmd/zetae2e/config/localnet.yml View secret
11478176 Triggered Generic High Entropy Secret 77e83a3 cmd/zetae2e/config/localnet.yml View secret
11759679 Triggered Generic High Entropy Secret 77e83a3 cmd/zetae2e/local/accounts.go View secret
11033145 Triggered Generic High Entropy Secret 4b13c38 cmd/zetae2e/local/accounts.go View secret
11033146 Triggered Generic High Entropy Secret 4b13c38 cmd/zetae2e/local/accounts.go View secret
11759679 Triggered Generic High Entropy Secret 4b13c38 cmd/zetae2e/local/accounts.go View secret
🛠 Guidelines to remediate hardcoded secrets
  1. Understand the implications of revoking this secret by investigating where it is used in your code.
  2. Replace and store your secret safely. Learn here the best practices.
  3. Revoke and rotate this secret.
  4. If possible, rewrite git history. Rewriting git history is not a trivial act. You might completely break other contributing developers' workflow and you risk accidentally deleting legitimate data.

To avoid such incidents in the future consider


🦉 GitGuardian detects secrets in your source code to help developers and security teams secure the modern development process. You are seeing this because you or someone else with access to this repository has authorized GitGuardian to scan your pull request.

@gartnera
Copy link
Member

gartnera commented Jun 26, 2024

Can you do a release on https://github.com/zeta-chain/ci-testing-node to validate it's all working correctly?

Update: ahh nvm I see https://github.com/zeta-chain/ci-testing-node/releases/tag/v02

@CharlieMc0
Copy link
Member Author

CharlieMc0 commented Jun 26, 2024

Yes already done here for a couple of binaries - https://github.com/zeta-chain/ci-testing-node/releases/tag/v02
A new one with all binaries renabled is running now and should be done in a few minutes. https://github.com/zeta-chain/ci-testing-node/releases/tag/v03

Copy link
Member

@lumtis lumtis left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@gartnera gartnera enabled auto-merge (squash) June 27, 2024 16:54
@gartnera gartnera merged commit ef8470c into zeta-chain:develop Jun 27, 2024
10 of 11 checks passed
@CharlieMc0 CharlieMc0 deleted the artifact-signing branch June 27, 2024 19:26
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
ci Changes to CI pipeline or github actions
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants