-
Notifications
You must be signed in to change notification settings - Fork 119
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
ci: enable artifact attenstations #2388
Conversation
Important Review skippedReview was skipped due to path filters Files ignored due to path filters (4)
You can disable this status message by setting the Thank you for using CodeRabbit. We offer it for free to the OSS community and would appreciate your support in helping us grow. If you find it useful, would you consider giving us a shout-out on your favorite social media? TipsChatThere are 3 ways to chat with CodeRabbit:
Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments. CodeRabbit Commands (invoked as PR comments)
Additionally, you can add CodeRabbit Configration File (
|
|
GitGuardian id | GitGuardian status | Secret | Commit | Filename | |
---|---|---|---|---|---|
10046624 | Ignored | Generic High Entropy Secret | 77e83a3 | cmd/zetae2e/local/accounts.go | View secret |
10046624 | Ignored | Generic High Entropy Secret | 77e83a3 | cmd/zetae2e/config/localnet.yml | View secret |
10046625 | Ignored | Generic High Entropy Secret | 77e83a3 | cmd/zetae2e/config/localnet.yml | View secret |
10046625 | Ignored | Generic High Entropy Secret | 77e83a3 | cmd/zetae2e/local/accounts.go | View secret |
11033143 | Triggered | Generic High Entropy Secret | 77e83a3 | cmd/zetae2e/local/accounts.go | View secret |
11033143 | Triggered | Generic High Entropy Secret | 77e83a3 | cmd/zetae2e/config/local.yml | View secret |
11033143 | Triggered | Generic High Entropy Secret | 77e83a3 | cmd/zetae2e/config/localnet.yml | View secret |
11033144 | Triggered | Generic High Entropy Secret | 77e83a3 | cmd/zetae2e/config/localnet.yml | View secret |
11033144 | Triggered | Generic High Entropy Secret | 77e83a3 | cmd/zetae2e/local/accounts.go | View secret |
11033145 | Triggered | Generic High Entropy Secret | 77e83a3 | cmd/zetae2e/local/accounts.go | View secret |
11033145 | Triggered | Generic High Entropy Secret | 77e83a3 | cmd/zetae2e/config/localnet.yml | View secret |
11033146 | Triggered | Generic High Entropy Secret | 77e83a3 | cmd/zetae2e/local/accounts.go | View secret |
11033146 | Triggered | Generic High Entropy Secret | 77e83a3 | cmd/zetae2e/config/localnet.yml | View secret |
11478175 | Triggered | Generic High Entropy Secret | 77e83a3 | cmd/zetae2e/config/localnet.yml | View secret |
11478176 | Triggered | Generic High Entropy Secret | 77e83a3 | cmd/zetae2e/config/localnet.yml | View secret |
11759679 | Triggered | Generic High Entropy Secret | 77e83a3 | cmd/zetae2e/local/accounts.go | View secret |
11033145 | Triggered | Generic High Entropy Secret | 4b13c38 | cmd/zetae2e/local/accounts.go | View secret |
11033146 | Triggered | Generic High Entropy Secret | 4b13c38 | cmd/zetae2e/local/accounts.go | View secret |
11759679 | Triggered | Generic High Entropy Secret | 4b13c38 | cmd/zetae2e/local/accounts.go | View secret |
🛠 Guidelines to remediate hardcoded secrets
- Understand the implications of revoking this secret by investigating where it is used in your code.
- Replace and store your secret safely. Learn here the best practices.
- Revoke and rotate this secret.
- If possible, rewrite git history. Rewriting git history is not a trivial act. You might completely break other contributing developers' workflow and you risk accidentally deleting legitimate data.
To avoid such incidents in the future consider
- following these best practices for managing and storing secrets including API keys and other credentials
- install secret detection on pre-commit to catch secret before it leaves your machine and ease remediation.
🦉 GitGuardian detects secrets in your source code to help developers and security teams secure the modern development process. You are seeing this because you or someone else with access to this repository has authorized GitGuardian to scan your pull request.
Can you do a release on https://github.com/zeta-chain/ci-testing-node to validate it's all working correctly? Update: ahh nvm I see https://github.com/zeta-chain/ci-testing-node/releases/tag/v02 |
Yes already done here for a couple of binaries - https://github.com/zeta-chain/ci-testing-node/releases/tag/v02 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
…ode into artifact-signing
Description
Enables GitHub attestations to verify the binaries available on our releases page were built by our CI.
More info about GitHub attestations here
Attestations will be available to view https://github.com/zeta-chain/node/attestations, as a JSON file attached to the releases page, and at https://search.sigstore.dev/.
Closes:
Type of change
How Has This Been Tested?
Please describe the tests that you ran to verify your changes. Include instructions and any relevant details so others can reproduce.
Checklist: