Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

refactor(observer): rename MsgAddBlameVote to MsgVoteBlame #2290

Merged
merged 8 commits into from
May 30, 2024

Conversation

lumtis
Copy link
Member

@lumtis lumtis commented May 29, 2024

Description

To keep consistency with all voting messages

Closes: #2201

Copy link

!!!WARNING!!!
nosec detected in the following files: x/observer/client/cli/tx_vote_blame.go

Be very careful about using #nosec in code. It can be a quick way to suppress security warnings and move forward with development, it should be employed with caution. Suppressing warnings with #nosec can hide potentially serious vulnerabilities. Only use #nosec when you're absolutely certain that the security issue is either a false positive or has been mitigated in another way.

Only suppress a single rule (or a specific set of rules) within a section of code, while continuing to scan for other problems. To do this, you can list the rule(s) to be suppressed within the #nosec annotation, e.g: /* #nosec G401 */ or //#nosec G201 G202 G203
Broad #nosec annotations should be avoided, as they can hide other vulnerabilities. The CI will block you from merging this PR until you remove #nosec annotations that do not target specific rules.

Pay extra attention to the way #nosec is being used in the files listed above.

@github-actions github-actions bot added the nosec label May 29, 2024
Copy link

codecov bot commented May 29, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 69.07%. Comparing base (85861be) to head (ff067ce).

Additional details and impacted files

Impacted file tree graph

@@           Coverage Diff            @@
##           develop    #2290   +/-   ##
========================================
  Coverage    69.07%   69.07%           
========================================
  Files          269      269           
  Lines        16436    16436           
========================================
  Hits         11353    11353           
  Misses        4599     4599           
  Partials       484      484           
Files Coverage Δ
x/crosschain/types/authz.go 100.00% <100.00%> (ø)
x/observer/keeper/msg_server_vote_blame.go 92.00% <100.00%> (ø)
x/observer/types/message_vote_blame.go 100.00% <100.00%> (ø)
zetaclient/zetacore/tx.go 53.72% <100.00%> (ø)

@lumtis lumtis marked this pull request as ready for review May 29, 2024 15:55
Copy link
Contributor

@kingpinXD kingpinXD left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm , left a minor comment

@lumtis lumtis merged commit 8eadf56 into develop May 30, 2024
19 checks passed
@lumtis lumtis deleted the rename/add-blame-vote branch May 30, 2024 07:59
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Rename MsgAddBlameVote to MsgVoteBlame
3 participants