Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ci: add nightly performance testing, update localnet Docker image to Debian Bookworm, remove unnecessary build-jet runners. #2285

Merged
merged 14 commits into from
May 30, 2024

Conversation

gzukel
Copy link
Contributor

@gzukel gzukel commented May 29, 2024

Description

ci: add nightly performance testing, update localnet Docker image to Debian Bookworm, remove unnecessary build-jet runners.

Closes: DEVOP-699

Type of change

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • This change requires a documentation update
  • CI Updates

How Has This Been Tested?

The docker image has been built locally to validate it builds and tested. Need to merge to register the performance pipeline for testing.

  • Tested CCTX in localnet
  • Tested in development environment
  • Go unit tests
  • Go integration tests
  • Tested via GitHub Actions
  • Locally

Checklist:

  • I have added unit tests that prove my fix feature works

…eded, and changed localnet docker image to use debian-bookworm
@github-actions github-actions bot added the ci Changes to CI pipeline or github actions label May 29, 2024
…eded, and changed localnet docker image to use debian-bookworm
@gartnera
Copy link
Member

zetae2e: /lib/x86_64-linux-gnu/libc.so.6: version `GLIBC_2.32' not found (required by zetae2e)

e2e has glibc version missmatch issues. You need to upgrade the orchestrator too.

Copy link
Member

@lumtis lumtis left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, minor comment for changelog

Copy link

!!!WARNING!!!
nosec detected in the following files: .github/workflows/sast-linters.yml

Be very careful about using #nosec in code. It can be a quick way to suppress security warnings and move forward with development, it should be employed with caution. Suppressing warnings with #nosec can hide potentially serious vulnerabilities. Only use #nosec when you're absolutely certain that the security issue is either a false positive or has been mitigated in another way.

Only suppress a single rule (or a specific set of rules) within a section of code, while continuing to scan for other problems. To do this, you can list the rule(s) to be suppressed within the #nosec annotation, e.g: /* #nosec G401 */ or //#nosec G201 G202 G203
Broad #nosec annotations should be avoided, as they can hide other vulnerabilities. The CI will block you from merging this PR until you remove #nosec annotations that do not target specific rules.

Pay extra attention to the way #nosec is being used in the files listed above.

@github-actions github-actions bot added the nosec label May 29, 2024
@gzukel gzukel requested review from kingpinXD, lumtis and gartnera May 30, 2024 01:10
@gzukel gzukel requested a review from CryptoFewka May 30, 2024 14:50
@gzukel gzukel requested a review from gartnera May 30, 2024 15:38
@gzukel gzukel requested a review from gartnera May 30, 2024 15:41
@gzukel gzukel merged commit 6423a33 into develop May 30, 2024
19 checks passed
@gzukel gzukel deleted the ci-add-performance-nightly-pipeline-update-runners branch May 30, 2024 16:25
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
ci Changes to CI pipeline or github actions nosec
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants