test: custom mempool unit tests

[skosito]

Description

Contains unit tests for priority mempool and custom proposal handler. These tests are forked from cosmos-sdk 0.47 codebase, but also extended on someplaces where we are using custom sender_with_nonce.go to handle ethermint txs, mostly on Insert method on priority mempool and selecting txs in handler. I marked those changes with comments, tried to keep same tests style.

Closes: #2183

Type of change

Unit tests

How Has This Been Tested?

Please describe the tests that you ran to verify your changes. Include instructions and any relevant details so others can reproduce.

• Tested CCTX in localnet
• Tested in development environment
• Go unit tests
• Go integration tests
• Tested via GitHub Actions

Checklist:

• I have added unit tests that prove my fix feature works

[codecov]

Codecov Report

Attention: Patch coverage is 66.66667% with 1 lines in your changes are missing coverage. Please review.

Project coverage is 68.80%. Comparing base (c0026b9) to head (c3a2402).

Additional details and impacted files

@@             Coverage Diff             @@
##           develop    #2199      +/-   ##
===========================================
+ Coverage    67.99%   68.80%   +0.80%     
===========================================
  Files          259      261       +2     
  Lines        16030    16250     +220     
===========================================
+ Hits         10900    11180     +280     
+ Misses        4669     4589      -80     
- Partials       461      481      +20     

Files	Coverage Δ
pkg/mempool/custom_proposal_handler.go	71.92% <100.00%> (ø)
pkg/mempool/priority_nonce_mempool.go	90.42% <ø> (ø)
pkg/mempool/senders_with_nonce.go	87.50% <100.00%> (ø)
app/app.go	2.18% <0.00%> (ø)

[github-actions]

!!!WARNING!!!
nosec detected in the following files: pkg/mempool/custom_proposal_handler.go

Be very careful about using #nosec in code. It can be a quick way to suppress security warnings and move forward with development, it should be employed with caution. Suppressing warnings with #nosec can hide potentially serious vulnerabilities. Only use #nosec when you're absolutely certain that the security issue is either a false positive or has been mitigated in another way.

Only suppress a single rule (or a specific set of rules) within a section of code, while continuing to scan for other problems. To do this, you can list the rule(s) to be suppressed within the #nosec annotation, e.g: /* #nosec G401 */ or //#nosec G201 G202 G203
Broad #nosec annotations should be avoided, as they can hide other vulnerabilities. The CI will block you from merging this PR until you remove #nosec annotations that do not target specific rules.

Pay extra attention to the way #nosec is being used in the files listed above.

[skosito]

I don't think we have this file in codecov scope. In general I don't think it is relevant to have the app package in codecov because it is generic logic but for this one this would make sense since we have a customized implementation.

We could also consider moving the mem pool priority logic in pkg as an independant package

moved everything mempool related to pkg file, added more tests not present in forked tests, coverage of that folder is now 83%

[lumtis]

LGTM

[gitguardian]

⚠️ GitGuardian has uncovered 2 secrets following the scan of your pull request.

Please consider investigating the findings and remediating the incidents. Failure to do so may lead to compromising the associated services or software components.

🔎 Detected hardcoded secrets in your pull request

GitGuardian id	GitGuardian status	Secret	Commit	Filename
11033145	Triggered	Generic High Entropy Secret	cbb972e	cmd/zetae2e/local/accounts.go	View secret
11033146	Triggered	Generic High Entropy Secret	cbb972e	cmd/zetae2e/local/accounts.go	View secret

🛠 Guidelines to remediate hardcoded secrets

1. Understand the implications of revoking this secret by investigating where it is used in your code.
2. Replace and store your secret safely. Learn here the best practices.
3. Revoke and rotate this secret.
4. If possible, rewrite git history. Rewriting git history is not a trivial act. You might completely break other contributing developers' workflow and you risk accidentally deleting legitimate data.

To avoid such incidents in the future consider

• following these best practices for managing and storing secrets including API keys and other credentials
• install secret detection on pre-commit to catch secret before it leaves your machine and ease remediation.

---

^{🦉 GitGuardian detects secrets in your source code to help developers and security teams secure the modern development process. You are seeing this because you or someone else with access to this repository has authorized GitGuardian to scan your pull request.}