Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ci: Automate GitHub Release Status Update Based on ZetaChain Governance Proposals #2192

Merged

Conversation

gzukel
Copy link
Contributor

@gzukel gzukel commented May 15, 2024

Description

  • Added pipeline that runs on a 10 minute timer. The pipeline watches the network for governance proposals within the last week with software upgrade type and checks if the current network height matches the proposal height.
  • If the proposal height matches network height it waits until the network is processing blocks.
  • Once the height has been met and network is processing blocks it will update the release with the same title/name as the title of the governance proposal and change it from pre-release to release.

Closes: DEVOPS-575

Type of change

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • This change requires a documentation update
  • CI

How Has This Been Tested?

I tested the code locally except the are no proposals that meet the criteria so I can't test the release status change. Also, can't test pipeline until its merged for the first time. This PR is to register the pipeline for testing.

  • Tested CCTX in localnet
  • Tested in development environment
  • Go unit tests
  • Go integration tests
  • Tested via GitHub Actions
  • Local Testing

Checklist:

  • I have added unit tests that prove my fix feature works

…ease has gone live i.e. the upgrade height is met and the network is processing blocks again. The script will then update the github release from pre-release to release as long as the release name matches the release title from the governance proposal
@gzukel gzukel requested a review from a team as a code owner May 15, 2024 22:10
@github-actions github-actions bot added the ci Changes to CI pipeline or github actions label May 15, 2024
@gzukel gzukel requested a review from skosito May 15, 2024 22:18
Copy link
Contributor

@morde08 morde08 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@gzukel gzukel merged commit ef9edc5 into develop May 15, 2024
21 checks passed
@gzukel gzukel deleted the add-pipeline-for-updating-release-status-automatically branch May 15, 2024 23:40
lumtis pushed a commit that referenced this pull request May 16, 2024
…ce Proposals (#2192)

* adding pipeline to automatically update the release status when a release has gone live i.e. the upgrade height is met and the network is processing blocks again. The script will then update the github release from pre-release to release as long as the release name matches the release title from the governance proposal

* updated links to new all that node links
lumtis added a commit that referenced this pull request May 17, 2024
…tests structure (#2181)

* add some spacing

* some clean up

* add more assertions to zevm mp

* changelog

* reorganize e2e tests name

* create file per test

* fix error

* some var name fix in zevm mp tests

* add a no revert test dapp contract

* add zevm mp revert fail test

* fix zevm revert fail

* evm to zevm revert fail

* remove redundant types

* change changelogs

* Update changelog.md

Co-authored-by: skosito <[email protected]>

* ci: fix docker release pipeline tag issue. (#2189)

* updated the docker build to utilize the github event release title and removed the mac build because the arm build covers that.

* updated change log

* ci: fixed the conditional for non release runs of the docker build (#2191)

* ci: fixed the conditional for non release runs of the docker build

* ci: Automate GitHub Release Status Update Based on ZetaChain Governance Proposals (#2192)

* adding pipeline to automatically update the release status when a release has gone live i.e. the upgrade height is met and the network is processing blocks again. The script will then update the github release from pre-release to release as long as the release name matches the release title from the governance proposal

* updated links to new all that node links

* fix(e2e): upgrade tests (#2190)

* fix(e2e): correct upgrade-host hostname

* fix light upgrade

* remove pointless tr

* add version change assertion

* formatting

* fix voting

* improve upgrade height check

* fix upgrade name

* refactor sleep logic

---------

Co-authored-by: Lucas Bertrand <[email protected]>

* add note for file per test

---------

Co-authored-by: skosito <[email protected]>
Co-authored-by: Grant Zukel <[email protected]>
Co-authored-by: Alex Gartner <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
ci Changes to CI pipeline or github actions
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants