-
Notifications
You must be signed in to change notification settings - Fork 119
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
refactor: add chain static info to chain struct #2071
Conversation
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## develop #2071 +/- ##
===========================================
- Coverage 70.17% 69.96% -0.21%
===========================================
Files 249 249
Lines 14135 14039 -96
===========================================
- Hits 9919 9823 -96
Misses 3758 3758
Partials 458 458
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
looks good in general, just couple small comments and question about observer params
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looking good, left some comments
Also @kingpinXD can we please make PR title more verbose? Like create a chain structure to store chain static information
I don't mind changing the title, but I feel like keeping the title brief with all the details in the description makes it look more accessible. Let me know if you feel otherwise |
The PR title should be descriptive for when you walk through the history on Github. It doesn't need to be very long but at list reflect the idea of the change |
Co-authored-by: Lucas Bertrand <[email protected]>
Description
Refactor the chain struct to include all metadata required for the the chain .
Closes: #1477
Type of change
How Has This Been Tested?
Please describe the tests that you ran to verify your changes. Include instructions and any relevant details so others can reproduce.
Checklist: