Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

refactor: add chain static info to chain struct #2071

Merged
merged 19 commits into from
Apr 29, 2024
Merged

Conversation

kingpinXD
Copy link
Contributor

Description

Refactor the chain struct to include all metadata required for the the chain .
Closes: #1477

Type of change

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • This change requires a documentation update

How Has This Been Tested?

Please describe the tests that you ran to verify your changes. Include instructions and any relevant details so others can reproduce.

  • Tested CCTX in localnet
  • Tested in development environment
  • Go unit tests
  • Go integration tests
  • Tested via GitHub Actions

Checklist:

  • I have added unit tests that prove my fix feature works

Copy link

codecov bot commented Apr 24, 2024

Codecov Report

Attention: Patch coverage is 88.79310% with 13 lines in your changes are missing coverage. Please review.

Project coverage is 69.96%. Comparing base (3e8f2e6) to head (20c422b).

Additional details and impacted files

Impacted file tree graph

@@             Coverage Diff             @@
##           develop    #2071      +/-   ##
===========================================
- Coverage    70.17%   69.96%   -0.21%     
===========================================
  Files          249      249              
  Lines        14135    14039      -96     
===========================================
- Hits          9919     9823      -96     
  Misses        3758     3758              
  Partials       458      458              
Files Coverage Δ
pkg/chains/bitcoin.go 100.00% <100.00%> (ø)
pkg/chains/chain.go 96.11% <100.00%> (-0.61%) ⬇️
pkg/chains/chains.go 100.00% <100.00%> (ø)
pkg/chains/status.go 100.00% <100.00%> (ø)
x/crosschain/migrations/v5/migrate.go 83.60% <100.00%> (ø)
...hain/types/message_vote_on_observed_outbound_tx.go 100.00% <100.00%> (ø)
x/observer/keeper/msg_server_vote_tss.go 100.00% <100.00%> (ø)
x/observer/types/chain_params.go 99.17% <100.00%> (ø)
x/observer/types/message_vote_tss.go 100.00% <100.00%> (ø)
x/observer/types/observer_set.go 100.00% <100.00%> (ø)
... and 8 more

@kingpinXD kingpinXD marked this pull request as ready for review April 24, 2024 05:00
Copy link
Contributor

@skosito skosito left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

looks good in general, just couple small comments and question about observer params

@kingpinXD kingpinXD requested review from lumtis and skosito April 24, 2024 17:32
Copy link
Member

@lumtis lumtis left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looking good, left some comments

Also @kingpinXD can we please make PR title more verbose? Like create a chain structure to store chain static information

@kingpinXD
Copy link
Contributor Author

Looking good, left some comments

Also @kingpinXD can we please make PR title more verbose? Like create a chain structure to store chain static information

I don't mind changing the title, but I feel like keeping the title brief with all the details in the description makes it look more accessible. Let me know if you feel otherwise

@lumtis
Copy link
Member

lumtis commented Apr 25, 2024

Looking good, left some comments
Also @kingpinXD can we please make PR title more verbose? Like create a chain structure to store chain static information

I don't mind changing the title, but I feel like keeping the title brief with all the details in the description makes it look more accessible. Let me know if you feel otherwise

The PR title should be descriptive for when you walk through the history on Github. It doesn't need to be very long but at list reflect the idea of the change

@kingpinXD kingpinXD changed the title refactor: chains struct refactor: add chain static info to chain struct Apr 25, 2024
@kingpinXD kingpinXD requested a review from lumtis April 29, 2024 15:51
@kingpinXD kingpinXD merged commit 379a056 into develop Apr 29, 2024
21 checks passed
@kingpinXD kingpinXD deleted the refactor-chains branch April 29, 2024 16:57
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Refactor and simplify chain informations
3 participants