Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

refactor: fix lint issues #2059

Merged
merged 15 commits into from
Apr 22, 2024
Merged

refactor: fix lint issues #2059

merged 15 commits into from
Apr 22, 2024

Conversation

kingpinXD
Copy link
Contributor

@kingpinXD kingpinXD commented Apr 19, 2024

Description

Closes:

Type of change

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • This change requires a documentation update

How Has This Been Tested?

Please describe the tests that you ran to verify your changes. Include instructions and any relevant details so others can reproduce.

  • Tested CCTX in localnet
  • Tested in development environment
  • Go unit tests
  • Go integration tests
  • Tested via GitHub Actions

Checklist:

  • I have added unit tests that prove my fix feature works

@kingpinXD kingpinXD changed the title refactor : fix lint issues refactor: fix lint issues Apr 19, 2024
Copy link

codecov bot commented Apr 19, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 70.70%. Comparing base (f7e5c07) to head (33c7d90).

Additional details and impacted files

Impacted file tree graph

@@           Coverage Diff            @@
##           develop    #2059   +/-   ##
========================================
  Coverage    70.70%   70.70%           
========================================
  Files          252      252           
  Lines        14052    14052           
========================================
  Hits          9936     9936           
  Misses        3656     3656           
  Partials       460      460           
Files Coverage Δ
x/crosschain/keeper/grpc_query_cctx.go 91.01% <100.00%> (ø)
x/crosschain/keeper/grpc_query_gas_price.go 85.18% <100.00%> (ø)
...crosschain/keeper/grpc_query_in_tx_hash_to_cctx.go 89.74% <100.00%> (ø)
.../crosschain/keeper/grpc_query_last_block_height.go 85.71% <100.00%> (ø)
x/crosschain/keeper/grpc_query_out_tx_tracker.go 81.81% <100.00%> (ø)
x/crosschain/keeper/in_tx_tracker.go 93.22% <100.00%> (ø)
x/fungible/keeper/grpc_query_foreign_coins.go 85.18% <100.00%> (ø)
x/lightclient/keeper/grpc_query_block_header.go 82.60% <100.00%> (ø)
x/lightclient/keeper/grpc_query_chain_state.go 82.60% <100.00%> (ø)
x/observer/keeper/blame.go 95.12% <100.00%> (ø)
... and 4 more

@kingpinXD kingpinXD marked this pull request as ready for review April 19, 2024 21:40
@lumtis lumtis merged commit a124ffb into develop Apr 22, 2024
21 checks passed
@lumtis lumtis deleted the fix-lint branch April 22, 2024 05:49
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants