Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(chains): add Amoy testnet chain ID in static chain data #2006

Merged
merged 3 commits into from
Apr 12, 2024

Conversation

lumtis
Copy link
Member

@lumtis lumtis commented Apr 10, 2024

Description

Add Amoy testnet information

I think we can close #2002 with it. The best way to handle new chain to be integrated would be to implement #2005 instead

Closes: #2002

Copy link

codecov bot commented Apr 10, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 68.54%. Comparing base (d8ac99e) to head (7f59692).

Additional details and impacted files

Impacted file tree graph

@@             Coverage Diff             @@
##           develop    #2006      +/-   ##
===========================================
+ Coverage    68.52%   68.54%   +0.01%     
===========================================
  Files          236      236              
  Lines        13612    13620       +8     
===========================================
+ Hits          9328     9336       +8     
  Misses        3834     3834              
  Partials       450      450              
Files Coverage Δ
pkg/chains/chain.go 96.72% <100.00%> (+0.02%) ⬆️
pkg/chains/chains.go 100.00% <100.00%> (ø)

@lumtis lumtis merged commit 637c62e into develop Apr 12, 2024
21 checks passed
@lumtis lumtis deleted the feat/add-amoy-testnet branch April 12, 2024 08:01
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Investigate and add new chain IDs info in chains package depending of potential future considerations
3 participants