test: improve crosschain module coverage

[skosito]

Description

Bumps coverage to 88.68%.

• some header and proofs tests are not added because of this issue Reenable missing AddTracker tests and mock header/proof functionality for AddTracker and AddBlockHeader #1875

• events.go and migrator.go added to ignore in codecov

• i didnt add tests for past migrations

• didn't test tss vote message because it is moved in other PR

Closes: #1740 #1316

Type of change

Tests

How Has This Been Tested?

Please describe the tests that you ran to verify your changes. Include instructions and any relevant details so others can reproduce.

• Tested CCTX in localnet
• Tested in development environment
• Go unit tests
• Go integration tests
• Tested via GitHub Actions

Checklist:

• I have added unit tests that prove my fix feature works

[codecov]

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 58.46%. Comparing base (64b898c) to head (daa59f3).

Additional details and impacted files

@@             Coverage Diff             @@
##           develop    #1967      +/-   ##
===========================================
+ Coverage    55.71%   58.46%   +2.74%     
===========================================
  Files          242      234       -8     
  Lines        13554    13392     -162     
===========================================
+ Hits          7551     7829     +278     
+ Misses        5559     5159     -400     
+ Partials       444      404      -40     

Files	Coverage Δ
x/crosschain/genesis.go	100.00% <ø> (+9.30%)	⬆️
x/crosschain/keeper/cctx_utils.go	100.00% <100.00%> (+12.24%)	⬆️
.../crosschain/keeper/grpc_query_last_block_height.go	85.71% <100.00%> (+14.28%)	⬆️
x/crosschain/keeper/grpc_query_last_zeta_height.go	100.00% <100.00%> (+100.00%)	⬆️
x/crosschain/keeper/msg_server_gas_price_voter.go	100.00% <100.00%> (+100.00%)	⬆️
.../crosschain/keeper/msg_server_migrate_tss_funds.go	84.00% <100.00%> (+11.64%)	⬆️
x/crosschain/keeper/process_inbound.go	100.00% <100.00%> (+5.88%)	⬆️
x/crosschain/types/status.go	100.00% <ø> (+7.14%)	⬆️

... and 24 files with indirect coverage changes

[lumtis]

Just wanted to ping: for the TSS vote message tests are implemented here: #1966

[github-actions]

!!!WARNING!!!
nosec detected in the following files: x/crosschain/keeper/grpc_query_zeta_conversion_rate_test.go

Be very careful about using #nosec in code. It can be a quick way to suppress security warnings and move forward with development, it should be employed with caution. Suppressing warnings with #nosec can hide potentially serious vulnerabilities. Only use #nosec when you're absolutely certain that the security issue is either a false positive or has been mitigated in another way.

Only suppress a single rule (or a specific set of rules) within a section of code, while continuing to scan for other problems. To do this, you can list the rule(s) to be suppressed within the #nosec annotation, e.g: /* #nosec G401 */ or //#nosec G201 G202 G203
Broad #nosec annotations should be avoided, as they can hide other vulnerabilities. The CI will block you from merging this PR until you remove #nosec annotations that do not target specific rules.

Pay extra attention to the way #nosec is being used in the files listed above.

[lumtis]

Looks great overall.
Wondering if we can do move coverage here https://app.codecov.io/gh/zeta-chain/node/pull/1967/blob/x/crosschain/keeper/evm_deposit.go

• Adding some data in ctx.TxBytes to cover L29
• Covering ProcessLogs
  Also for https://app.codecov.io/gh/zeta-chain/node/pull/1967/blob/x/crosschain/keeper/msg_server_migrate_tss_funds.go
  Maybe we can add coverage for Bitcoin chain case? L157

[kingpinXD]

looks good, left some minor comments