-
Notifications
You must be signed in to change notification settings - Fork 119
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
refactor: change important metrics on port 8123 to be prometheus compatible #1885
Conversation
!!!WARNING!!! Be very careful about using Only suppress a single rule (or a specific set of rules) within a section of code, while continuing to scan for other problems. To do this, you can list the rule(s) to be suppressed within the #nosec annotation, e.g: /* #nosec G401 */ or //#nosec G201 G202 G203 Pay extra attention to the way |
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## develop #1885 +/- ##
===========================================
+ Coverage 44.62% 44.84% +0.22%
===========================================
Files 219 219
Lines 12771 12708 -63
===========================================
Hits 5699 5699
+ Misses 6630 6567 -63
Partials 442 442
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The formatting looks good based on your comments. This will be helpful. Thanks!
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM just one minor comment
Description
As stated in issue, some of the metrics exposed in telemetry server endpoints should be refactored to be prometheus compatible as the other zetaclient metrics.
Moved to metrics:
Still in telemetry, seems like it is more appropriate than metrics:
looks like this:
version (named info so it is same as go_info)
for reference, go_info looks like this:
last start time (using
SetToCurrentTime
from prometheus on zetaclient start)utxo_number (not sure if it supposed to be count, but in telemetry it was more like gauge, so i kept gauge):
last scanned block number per chain (gauge, maybe it can be used to send alerts if its not increasing)
last core block number (same as above)
Closes: #1772
Type of change
Metrics refactor
How Has This Been Tested?
Please describe the tests that you ran to verify your changes. Include instructions and any relevant details so others can reproduce.
Checklist: