Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: added new cmd "zetatool" and sub cmd filterdeposits #1884

Merged
merged 22 commits into from
Mar 21, 2024
Merged

Conversation

kevinssgh
Copy link
Contributor

@kevinssgh kevinssgh commented Mar 12, 2024

Description

A new command was added to the node repository as a utility tool. The first tool added is a filter for missed inbound transactions on BTC and ETH networks.

Closes: #1846

Type of change

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • This change requires a documentation update

How Has This Been Tested?

Please describe the tests that you ran to verify your changes. Include instructions and any relevant details so others can reproduce.

  • Tested CCTX in localnet
  • Tested in development environment
  • Go unit tests
  • Go integration tests
  • Tested via GitHub Actions

Checklist:

  • I have added unit tests that prove my fix feature works

Copy link

github-actions bot commented Mar 12, 2024

!!!WARNING!!!
nosec detected in the following files: cmd/zetatool/filterdeposit/btc.go, cmd/zetatool/filterdeposit/evm.go

Be very careful about using #nosec in code. It can be a quick way to suppress security warnings and move forward with development, it should be employed with caution. Suppressing warnings with #nosec can hide potentially serious vulnerabilities. Only use #nosec when you're absolutely certain that the security issue is either a false positive or has been mitigated in another way.

Only suppress a single rule (or a specific set of rules) within a section of code, while continuing to scan for other problems. To do this, you can list the rule(s) to be suppressed within the #nosec annotation, e.g: /* #nosec G401 */ or //#nosec G201 G202 G203
Broad #nosec annotations should be avoided, as they can hide other vulnerabilities. The CI will block you from merging this PR until you remove #nosec annotations that do not target specific rules.

Pay extra attention to the way #nosec is being used in the files listed above.

@github-actions github-actions bot added the nosec label Mar 12, 2024
@kevinssgh kevinssgh marked this pull request as ready for review March 14, 2024 19:24
Copy link

gitguardian bot commented Mar 18, 2024

️✅ There are no secrets present in this pull request anymore.

If these secrets were true positive and are still valid, we highly recommend you to revoke them.
Once a secret has been leaked into a git repository, you should consider it compromised, even if it was deleted immediately.
Find here more information about risks.


🦉 GitGuardian detects secrets in your source code to help developers and security teams secure the modern development process. You are seeing this because you or someone else with access to this repository has authorized GitGuardian to scan your pull request.

Our GitHub checks need improvements? Share your feedbacks!

@kevinssgh kevinssgh requested a review from lumtis March 19, 2024 15:46
@kevinssgh kevinssgh requested a review from ws4charlie March 20, 2024 16:32
@lumtis lumtis merged commit 39bca23 into develop Mar 21, 2024
21 checks passed
@lumtis lumtis deleted the intx-filter branch March 21, 2024 13:55
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Add script for missing observations
3 participants