Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

test: emissions unit test #1767

Merged
merged 20 commits into from
Feb 22, 2024
Merged

test: emissions unit test #1767

merged 20 commits into from
Feb 22, 2024

Conversation

kingpinXD
Copy link
Contributor

@kingpinXD kingpinXD commented Feb 16, 2024 •
edited
Loading

Description

Type of change

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • This change requires a documentation update

How Has This Been Tested?

Please describe the tests that you ran to verify your changes. Include instructions and any relevant details so others can reproduce.

  • Tested CCTX in localnet
  • Tested in development environment
  • Go unit tests
  • Go integration tests
  • Tested via GitHub Actions

Checklist:

  • I have added unit tests that prove my fix feature works

@github-actions GitHub Actions
Copy link

!!!WARNING!!!
nosec detected in the following files: x/emissions/abci_test.go

Be very careful about using #nosec in code. It can be a quick way to suppress security warnings and move forward with development, it should be employed with caution. Suppressing warnings with #nosec can hide potentially serious vulnerabilities. Only use #nosec when you're absolutely certain that the security issue is either a false positive or has been mitigated in another way.

Only suppress a single rule (or a specific set of rules) within a section of code, while continuing to scan for other problems. To do this, you can list the rule(s) to be suppressed within the #nosec annotation, e.g: /* #nosec G401 */ or //#nosec G201 G202 G203
Broad #nosec annotations should be avoided, as they can hide other vulnerabilities. The CI will block you from merging this PR until you remove #nosec annotations that do not target specific rules.

Pay extra attention to the way #nosec is being used in the files listed above.

@github-actions github-actions bot added the nosec label Feb 16, 2024
@kingpinXD kingpinXD marked this pull request as ready for review February 16, 2024 16:59
lumtis
lumtis reviewed Feb 19, 2024
View reviewed changes
@kingpinXD kingpinXD merged commit c68c21d into develop Feb 22, 2024
20 checks passed
@kingpinXD kingpinXD deleted the emissions-test branch February 22, 2024 18:07
lumtis pushed a commit that referenced this pull request Mar 5, 2024
@kingpinXD @lumtis
test: emissions unit test (#1767)
9d26592
lumtis added a commit that referenced this pull request Mar 12, 2024
@lumtis @kingpinXD
@skosito @ws4charlie
test: add admin and performance test and fix upgrade test (#1805)
71a889b 
* simplify docker compose

* fix makefi;e

* add new version

* type

* fix restart client

* some fixes

* add light upgrade test

* fix gov sending

* add admin function test command

* performance test

* fix lint

* add pprof port

* some fixes in tests

* test: emissions unit test (#1767)

* ci: run build workflow on develop push for code coverage generation (#1793)

* refactor: zetaclient metrics (#1783)

* Refactor zetaclient metrics

* Fix blame counter init

* Add changelog entry

* Add unreleased to changelog

* Remove blank line

* feat: initiated feature of zetaclient-restricted-address (#1790)

* initiated feature of zetaclient-banned-address

* fix some issues in e2e tests

* fix gosec issues

* some unit tests, comments and refactor

* unified log prints for restricted address detection

* move restricted address to Unreleased section

* improved compliance log prints

* update compliance log print according to CharlieMc

* chore(codecov.yml): fix ignore extension (#1814)

* chore(codecov.yml): fix ignore extension

* changelog

* refactor: remove params from config and introduce app context (#1774)

* refactor(`crosschain`): move ballot voting logic into `observer` (#1511)

* move logic for ballot voting for inbound

* fix mocks

* goimports

* changelog

* fix unit tests

* fix CI =

* x/observer/keeper/vote_outbound.go x/crosschain/types/expected_keepers.go x/crosschain/keeper/msg_server_vote_outbound_tx.go

* update mocks

* refactor finalized check

* make generate

* initialize vote inbound tests

* add sdk keepers in observer testutil

* implement mock option for observer

* inbound vote test

* initialize outbound tests

* goimports

* vote outbound tests

* update changelog

* test with integration tests

* add isNew in vote_inbound

* add tests back

* use tmp context for ballot logic

* add new test for finalized ballot

* add not finzalized test

* remove unused comment

* fix bitcoin credentials

* change upgrade version

* fix performance tests

* handler

* fix setup handler

* add light flag and use it for upgrade tests

* fix username

* add performance test back

* Update cmd/zetae2e/local/ethereum.go

* stefan comments

* changelog

* fix

---------

Co-authored-by: Tanmay <[email protected]>
Co-authored-by: skosito <[email protected]>
Co-authored-by: Charlie Chen <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@lumtis lumtis lumtis approved these changes

@ws4charlie ws4charlie ws4charlie approved these changes

@brewmaster012 brewmaster012 Awaiting requested review from brewmaster012

@kevinssgh kevinssgh Awaiting requested review from kevinssgh

@fadeev fadeev Awaiting requested review from fadeev

@skosito skosito Awaiting requested review from skosito

Assignees
No one assigned
Labels
nosec
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

emissions : Add tests for emissions module using new constant block rewards
3 participants
@kingpinXD @lumtis @ws4charlie