-
Notifications
You must be signed in to change notification settings - Fork 120
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix: merge develop into inbound-tracker and unified proof verification #1292
fix: merge develop into inbound-tracker and unified proof verification #1292
Conversation
* update index * remove deprecated functions * make generate * add return value in message * initialize test * whitelist tests * make generate
* update function * regenerate interfaces * update for crosschain
…cksum format (#1261) * fix error message * compare with ETH address type * tests * goimport --------- Co-authored-by: brewmaster012 <[email protected]>
* initial commit * added queries and unit tests * added cli * fix parse error * fix parse error 2 * fix lint and test errors * ran make generate * update index for keygen * refactor query name * refactor key calculation * refactor lib name
* feed sataoshi/B to zetacore and check size limit * removed fee cap * replaced magic number 1000 with constant bytesPerKB * put lowerbound, upperbound limit on sizeLimit * use actual txSize for fee calculation --------- Co-authored-by: charliec <[email protected]>
….) (#1235) * cherry pick all hotfix from v10.0.x * adjusted code to for nosec * adusted error handling and code comments according to PR review feedback * cherry pick hotfix for bitcoin outbound performance and updated some log prints * cherry pick mock mainnet hotfix for duplicate payment on nonce 0 --------- Co-authored-by: charliec <[email protected]>
* initiated bitcoin header and proof * added smoke test for bitcoin merkle proof and RPC query * make generate * fix gosec and unit test * Update common/headers_test.go Co-authored-by: Lucas Bertrand <[email protected]> * code adjustment according to feedback of PR review * corrected a typo and added more comment to function * fix gosec error --------- Co-authored-by: charliec <[email protected]> Co-authored-by: Lucas Bertrand <[email protected]> Co-authored-by: brewmaster012 <[email protected]>
* read gas limit from smart contract * add more checks for gas limit
…1285) * change comment * add notice for ledger
!!!WARNING!!! Be very careful about using Only suppress a single rule (or a specific set of rules) within a section of code, while continuing to scan for other problems. To do this, you can list the rule(s) to be suppressed within the #nosec annotation, e.g: /* #nosec G401 */ or //#nosec G201 G202 G203 Pay extra attention to the way |
if strings.EqualFold(hash.TxHash, msg.TxHash) { | ||
isDup = true | ||
if isProven { | ||
hash.Proved = true |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Does this value get modified in the tracker? If not then the variable has no use here.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The hash.Proved
value is used nowhere for now. Moving forward, we'll gradually utilize the Proved
flag in a way that whenever a tracker hash gets its Proved
flag set to true
, it will be treated as a true hash of outTx/inTx and be trusted by any party.
Description
develop
intoinbound-tracker
branch.Closes:
Type of change
How Has This Been Tested?
Please describe the tests that you ran to verify your changes. Include instructions and any relevant details so others can reproduce.
Checklist: