fix: Mock mainnet begin block deployment fix btc duplicate payment #1259
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ws4charlie
requested review from
brewmaster012,
kingpinXD,
kevinssgh,
fadeev and
lumtis
as code owners
brewmaster012
approved these changes
Oct 9, 2023
lumtis
approved these changes
Oct 9, 2023
…le in bitcoin mainnet
lumtis
pushed a commit
that referenced
this pull request
Oct 16, 2023
* add begin blocked deployemnts for mock mainent * panic when telemetry server does not start * report bitcoin fee in sat/byte instead of stas/KB * compensate for the low gaslimit on BTC * fix: Mock mainnet begin block deployment fix btc duplicate payment (#1259) * special handling to avoid duplicate payment on bitcoin outbound nonce 0 * use cctx amount instead of txResult's amount because it's not available in bitcoin mainnet --------- Co-authored-by: charliec <[email protected]> * fix: Mock mainnet begin block deployment fix btc duplicate payment (#1266) * special handling to avoid duplicate payment on bitcoin outbound nonce 0 * use cctx amount instead of txResult's amount because it's not available in bitcoin mainnet * mockmain bootstrap from double payment on nonce 0 --------- Co-authored-by: charliec <[email protected]> * revert hard coded outTx hash for nonce 0 * removed division by 1000 in fee calculation (#1275) Co-authored-by: charliec <[email protected]> * try to fix smoketest due to BTC ZRC20 audit --------- Co-authored-by: Tanmay <[email protected]> Co-authored-by: Tanmay <[email protected]> Co-authored-by: Charlie Chen <[email protected]> Co-authored-by: charliec <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Duplicate payment happened to bitcoin outbound nonce 0.
payment1: https://blockstream.info/tx/71395db26ae81147dd79176e394c598b9480036c5ef6e44608b3356283168872
payment2: https://blockstream.info/tx/26aa6b32b7f16cc6671ac1419e91bac5fb78b5d24536df0da0120a3f75bf9116
This PR is to special handle nonce 0 to avoid duplicate payments.
Closes:
Type of change
How Has This Been Tested?
Please describe the tests that you ran to verify your changes. Include instructions and any relevant details so others can reproduce.
Checklist: