Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ci: add build workflow for release candidate builds #1161

Closed
wants to merge 3 commits into from

Conversation

CharlieMc0
Copy link
Member

Description

Adds a new workflow for release candidates that includes a set of binaries under a "prerelease" GitHub release.

This is one step towards the new CI workflow
release-workflow

Will not work until #1144 is merged in.

Type of change

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • This change requires a documentation update

How Has This Been Tested?

Limited testing - we can't really test this until after it has been merged in and the workflow is active.

Checklist:

  • I have added unit tests that prove my fix feature works

@CharlieMc0 CharlieMc0 self-assigned this Sep 20, 2023
@github-actions github-actions bot added the ci Changes to CI pipeline or github actions label Sep 20, 2023
Copy link
Member

@lumtis lumtis left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

These are changes where it might make more sense to require reviews from the infra team for merging.

Maybe we could set a CODEOWNER set for CI related PR?

# Primary repo maintainers
*             @protocol-team

# CI maintainers
.github/      @infra-team

@CharlieMc0
Copy link
Member Author

Replace by #1218

@CharlieMc0 CharlieMc0 closed this Sep 29, 2023
@lumtis lumtis deleted the ci-build-release-candidate branch October 27, 2023 23:19
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
ci Changes to CI pipeline or github actions
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants