Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Missing zero address check in #62

Merged
merged 3 commits into from
Jan 25, 2023

Conversation

andresaiello
Copy link
Collaborator

@andresaiello andresaiello commented Jan 24, 2023

Summary

  • Add zero address validation
    • Refactor a common error interface to share invalid address error in most of the contracts
  • Add zero address test
  • Regenerate typechain
  • Add missing immutable check

@andresaiello andresaiello marked this pull request as ready for review January 24, 2023 14:51
lucas-janon
lucas-janon previously approved these changes Jan 25, 2023
Copy link
Contributor

@lucas-janon lucas-janon left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 🎉

Signed-off-by: Andres Aiello <[email protected]>
Signed-off-by: Andres Aiello <[email protected]>
Signed-off-by: Andres Aiello <[email protected]>
@andresaiello andresaiello force-pushed the andy/pd-2428-missing-zero-address-check-in branch from 12a76c3 to a201e70 Compare January 25, 2023 16:06
@andresaiello andresaiello merged commit cfe525c into main Jan 25, 2023
@andresaiello andresaiello deleted the andy/pd-2428-missing-zero-address-check-in branch January 25, 2023 16:16
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants