Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add different strategies to swap #42

Merged
merged 11 commits into from
Sep 20, 2022
Merged

Add different strategies to swap #42

merged 11 commits into from
Sep 20, 2022

Conversation

andresaiello
Copy link
Collaborator

Summary

  • Refactor MultiChainSwap to use an interface in common
  • Add a new strategy using uniswap v3

@andresaiello andresaiello marked this pull request as ready for review August 11, 2022 19:36
lucas-janon
lucas-janon reviewed Aug 12, 2022
View reviewed changes
Copy link
Contributor

@lucas-janon lucas-janon left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Left a few small comments and we're good to go!

lucas-janon
lucas-janon approved these changes Sep 20, 2022
View reviewed changes
Copy link
Contributor

@lucas-janon lucas-janon left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@lucas-janon lucas-janon merged commit 77e3185 into main Sep 20, 2022
@lucas-janon lucas-janon deleted the aaiello/pd-628-add-different-strategies-to-swap branch September 20, 2022 19:04
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@lucas-janon lucas-janon lucas-janon approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@andresaiello @lucas-janon