Load ads directly instead of pulling from iframe #215
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| @@ -1,5 +1,13 @@ | |||
| import { test, expect } from '@playwright/test'; | |||
|
|
|||
| function srcEvaluate(node) { | |||
|
Would be good to leave a note on how to update the WLE test projects in the SDK README. |
limbofeather
approved these changes
Jun 26, 2024
utils/networking.js
Outdated
| document.head.appendChild(gifscript); | ||
|
|
||
| // Select baseDivId based on format, defaulting to the one for medium rectangle | ||
| if (format == 'billboard') { |
There was a problem hiding this comment.
Could all of this information on each format's attributes be in utils/formats.js?
There was a problem hiding this comment.
It probably could yeah, can do in a small followup if this deploys without issue
I've got an existing issue at #206 which would remove the need to manually build the test project, just haven't gotten around to figuring out the workflow yet |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR changes the behavior of the SDK to pull the wrapper in to the embedding page directly instead of going through the cross-origin frame, which was impacting viewability metrics. It also no longer initializes prebid resources if the ad unit ID provided is not a valid v4 uuid, along with a slight change to the A-Frame tests to account for varying image src.