Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

add flag to enable MulticastDNS #22

Merged
merged 1 commit into from
Jun 27, 2023
Merged

Conversation

Finkregh
Copy link
Contributor

No description provided.

@erikh
Copy link
Contributor

erikh commented Apr 11, 2023

LGTM

@erikh
Copy link
Contributor

erikh commented Apr 11, 2023

@laduke

@laduke
Copy link
Contributor

laduke commented Apr 11, 2023

Seems right. I feel like we had added this by default or something. Guess not.

Let me try to run it on a computer.

@erikh
Copy link
Contributor

erikh commented Apr 11, 2023 via email

@Finkregh
Copy link
Contributor Author

Finkregh commented Jun 19, 2023

Anything i can do here?

(sorry, fat-fingered the close/open 🙄 )

@Finkregh Finkregh closed this Jun 19, 2023
@Finkregh Finkregh reopened this Jun 19, 2023
@laduke
Copy link
Contributor

laduke commented Jun 26, 2023

Sorry for the delay. Just haven't had bandwidth to look at it.

One thing I'm thinking: eventually we'll have a flag for every option in systemd.network.
I'm wondering if there's a way around that.

What if the user could specify their own template, for example?

Then people wouldn't have to come plead for new flags.

@laduke
Copy link
Contributor

laduke commented Jun 27, 2023

Seems to work.

Resolvectl with and without -multicast-dns

         Protocols: -DefaultRoute +LLMNR +mDNS -DNSOverTLS DNSSEC=no/unsupported
         Protocols: -DefaultRoute +LLMNR -mDNS -DNSOverTLS DNSSEC=no/unsupported

@laduke laduke merged commit ef57478 into zerotier:main Jun 27, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants