upgrade trust-dns to v0.22 #221
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Erik Hollensbe <[email protected]>
|
Resolved in a slightly different way as a side-effect of #238 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This upgrades trust-dns to v0.22 and will likely be my last patch to this project. I checked
make test(which only runs--lib, not the integration tests) and all seemed to work fine, but a second validation pass would be a good idea.I'm still happy to offer help with cutting releases, it's especially tricky on windows but the brew tap is also a little finicky. I won't be providing patches any further as I don't want to involve myself in a conflict of interest for any future work I'm doing.
Wish you all the best, and may you have names for all your zerotier IPs.