Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Create an alternate network list endpoint #2212

Merged
merged 1 commit into from
Feb 1, 2024
Merged

Create an alternate network list endpoint #2212

merged 1 commit into from
Feb 1, 2024

Conversation

laduke
Copy link
Contributor

@laduke laduke commented Jan 31, 2024

Similar to recent PR for adding members2, it returns actual network objects instead of only network ids.
Also includes the total network count,
and each network has it's member counts in meta{}.

{
  "data": [
    {
      ...
      "id": "12345ec531867f2f",
      "objtype": "network",
      "ipAssignmentPools": [],
      "meta": {
        "authorizedMemberCount": 3,
        "totalMemberCount": 4
      },
      ...
    },
    {
    ...
    }
  ],
  "meta": {
    "networkCount": 2
  }
}

@laduke laduke marked this pull request as draft January 31, 2024 21:31
@danitheturtle
Copy link

fantastic! Much better than it is currently. Thanks!

@laduke laduke force-pushed the tl-extend-api-2 branch 3 times, most recently from 7c54ddc to 153086d Compare February 1, 2024 20:12
@laduke laduke changed the title Add /controller/networks2 endpoint Create an alternate network list endpoint Feb 1, 2024
@laduke laduke force-pushed the tl-extend-api-2 branch 2 times, most recently from c56d490 to ca98302 Compare February 1, 2024 20:36
Add /unstable/controller/network endpoint

Similar to /unstable/controller/network/{id}/member, it returns actual network objects,
instead of just network ids.
Also includes the total network count,
and each network has it's member counts in meta{}.
Base automatically changed from tl-extend-api-2 to main February 1, 2024 20:50
@laduke laduke marked this pull request as ready for review February 1, 2024 20:51
@laduke laduke merged commit 0ca8ae7 into main Feb 1, 2024
4 of 5 checks passed
@laduke laduke deleted the tl-extend-api-3 branch February 1, 2024 21:12
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants