Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix uploading of prebuilds to the GitHub tag #446

Merged
merged 2 commits into from
Apr 14, 2021

Conversation

aminya
Copy link
Member

@aminya aminya commented Apr 14, 2021

@aminya
Copy link
Member Author

aminya commented Apr 14, 2021

@captainsafia Hopefully, this will fix the prebuild uploading on GitHub tag creation. I updated the distros to Bionic and explicitly specified Node 12 and Electron 9.4.4 so they don't use some random old version that comes with the distro.

@aminya
Copy link
Member Author

aminya commented Apr 14, 2021

I think, after merging this, the previous GitHub tag should be deleted and a new one should be created with the same v5.2.1 version. After that, they hopefully start to upload again. 🤞🏻

@captainsafia
Copy link
Contributor

@aminya Thanks for the speedy fix! I'll merge this once the CI passes and push those tags again.

@aminya
Copy link
Member Author

aminya commented Apr 14, 2021

You're welcome! The Electron builds, which we need, are green. One of the tests on Mac is flaky, which may need some retrying in Travis.

@captainsafia
Copy link
Contributor

OK -- let's merge this and give it a go.

@captainsafia captainsafia merged commit e690b5d into zeromq:5.x Apr 14, 2021
@captainsafia
Copy link
Contributor

Looks like it's not picking up the latest Appveyor config in the tag.

I'll just go ahead and create a new one and see if that does the trick.

@captainsafia
Copy link
Contributor

Errrm -- it looks like something is afoot with publishing the assets up to the GH tag.

@aminya

This comment has been minimized.

@n-riesco
Copy link
Contributor

It looks like nodejs/node#33688 , but Appveyor is using v12.20.1 (that should have the fix).
Would using v14 be an option?

@aminya
Copy link
Member Author

aminya commented Apr 14, 2021

Yes, I made a PR. See this:
#447

@aminya aminya deleted the fix-prebuild-creation branch April 24, 2021 20:11
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants