-
-
Notifications
You must be signed in to change notification settings - Fork 217
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix uploading of prebuilds to the GitHub tag #446
Conversation
@captainsafia Hopefully, this will fix the prebuild uploading on GitHub tag creation. I updated the distros to Bionic and explicitly specified Node 12 and Electron 9.4.4 so they don't use some random old version that comes with the distro. |
I think, after merging this, the previous GitHub tag should be deleted and a new one should be created with the same v5.2.1 version. After that, they hopefully start to upload again. 🤞🏻 |
@aminya Thanks for the speedy fix! I'll merge this once the CI passes and push those tags again. |
You're welcome! The Electron builds, which we need, are green. One of the tests on Mac is flaky, which may need some retrying in Travis. |
OK -- let's merge this and give it a go. |
Looks like it's not picking up the latest Appveyor config in the tag. I'll just go ahead and create a new one and see if that does the trick. |
Errrm -- it looks like something is afoot with publishing the assets up to the GH tag. |
This comment has been minimized.
This comment has been minimized.
It looks like nodejs/node#33688 , but Appveyor is using v12.20.1 (that should have the fix). |
Yes, I made a PR. See this: |
Travis and Appveyor failed to upload the prebuilds to the GitHub tag.
https://github.com/zeromq/zeromq.js/releases/tag/v5.2.1
Previous failures:
https://ci.appveyor.com/project/zeromq/zeromq-js/builds/38706697
https://travis-ci.org/github/zeromq/zeromq.js/builds/767078872