Display ipc path in case of ENOENT exception #1301
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Peque
force-pushed
the
nosuchfile
branch
2 times, most recently
from
1ae10b3 to
f279299
Compare
Useful to see right in the traceback which ipc path caused the exception.
minrk
reviewed
Jun 27, 2019
| s.bind('ipc://{0}'.format(invalid_path)) | ||
| error_message = str(error.value) | ||
| assert invalid_path in error_message | ||
| assert "no such file or directory" in error_message.lower() |
There was a problem hiding this comment.
Can you add one more assert that error.errno == ENOENT?
There was a problem hiding this comment.
Thanks for the review!
I pushed a fixup with that change.
Tell me if it is good for you and I will squash it. Or feel free to squash it yourself before merging. 👍
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Useful to see right in the traceback which ipc path caused the
exception.