Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat add tag switch to disable form array of split comma format #4633

Merged
merged 2 commits into from
Feb 8, 2025

Conversation

xuerbujia
Copy link
Contributor

Resolve #4629

@kevwan
Copy link
Contributor

kevwan commented Feb 8, 2025

Thanks for your contribution! But your modification is too complex, just not splitting the string is OK to accept.

Copy link

codecov bot commented Feb 8, 2025

Codecov Report

Attention: Patch coverage is 53.48837% with 20 lines in your changes missing coverage. Please review.

Project coverage is 94.46%. Comparing base (8690859) to head (74e634a).
Report is 259 commits behind head on master.

Files with missing lines Patch % Lines
core/mapping/utils.go 17.39% 19 Missing ⚠️
core/mapping/unmarshaler.go 95.00% 1 Missing ⚠️
Additional details and impacted files
Files with missing lines Coverage Δ
core/mapping/fieldoptions.go 100.00% <ø> (ø)
core/mapping/unmarshaler.go 95.96% <95.00%> (-0.52%) ⬇️
core/mapping/utils.go 96.02% <17.39%> (-3.98%) ⬇️

... and 7 files with indirect coverage changes

@kevwan kevwan merged commit 507ff96 into zeromicro:master Feb 8, 2025
4 of 5 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

About the updated form array in v1.7.5
2 participants