Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Request]: patch for MechJeb (MJ) #58

Closed
zer0Kerbal opened this issue Mar 19, 2022 · 7 comments · Fixed by #52 or #103
Closed

[Request]: patch for MechJeb (MJ) #58

zer0Kerbal opened this issue Mar 19, 2022 · 7 comments · Fixed by #52 or #103
Assignees
@zer0Kerbal
Labels
type: discussion Questions, queries, posers, proposals and info that requires discussion. type: request Requested functionality, features, pages, workflows, endpoints, etc.

Comments

@zer0Kerbal
Copy link
Owner

zer0Kerbal commented Mar 19, 2022 •
edited
Loading

Description of the new feature / enhancement

add a compatibility patch for patch for MechJeb (MJ)

Proposed technical implementation details

  1. create the patch [MechJeb.cfg]
@zer0Kerbal zer0Kerbal added type: discussion Questions, queries, posers, proposals and info that requires discussion. type: request Requested functionality, features, pages, workflows, endpoints, etc. labels Mar 19, 2022
@zer0Kerbal zer0Kerbal changed the title [Request]: patch for ConnectedLivingSpaces (CLS) [Request]: patch for MechJeb (MJ) Mar 19, 2022
@zer0Kerbal zer0Kerbal mentioned this issue Mar 19, 2022
Merged
@zer0Kerbal zer0Kerbal self-assigned this Mar 19, 2022
@zer0Kerbal zer0Kerbal added this to the 1.3.99.0-adoption milestone Mar 19, 2022
@zer0Kerbal zer0Kerbal assigned zer0Kerbal and unassigned zer0Kerbal Mar 19, 2022
@zer0Kerbal
Copy link
Owner Author

@FuryFire2004

@FuryFire2004
Copy link
Contributor

huh

@FuryFire2004
Copy link
Contributor

did it not work cuz i have things i might need to add to it i was unsure

@FuryFire2004
Copy link
Contributor

depends if it worked

@zer0Kerbal zer0Kerbal linked a pull request Mar 19, 2022 that will close this issue
Create mechjeb patch #52
Merged
@FuryFire2004
Copy link
Contributor

nvm then

@FuryFire2004
Copy link
Contributor

i checked another mod's mecghjeb patch, it should work given mine functions the same pretty much

@zer0Kerbal
Copy link
Owner Author

i checked another mod's mecghjeb patch, it should work given mine functions the same pretty much

just the workflow. :D merged in so all is good, until it isn't. :)

zer0Kerbal added a commit that referenced this issue Mar 21, 2022
@zer0Kerbal @artwhaley
Localization
bd03cda 
### Localization

* [Agents.cfg]
  * update
  * localize
* closes #11 - Localization - English (United States) <en-us.cfg>
* updates #10 - Localization - Master

### Parts

* Stage I
  * combine multiple versions into one
* [tag] --> [tags]
* [drm-atlas-inter.cfg]
  * [category]
  * [vesselType]
* [drm-cabin-bay.cfg]
  * [mass] was 0.7, now 2.0
  * [maxTemp] now 3400, was 4400
* [drm-cabin-nobay.cfg]
* [drm-decoupler.cfg]
  * Update
    * [category] was Structural, now is Coupling
    * [maximum_drag] was = 0.02, now is 0.2
    * [minimum_drag] was = 0.0, now is 0.2
    * [angularDrag] was = 1, now is 2
    * [crashTolerance] = 6, was 15
    * [breakingForce] = 150, was 20000
    * [breakingTorque] = 150, was 20000
    * [maxTemp] = 2000, was 3400
    * [mass] = 0.05, was 0.1]
  * Add
    * [bulkheadProfiles] = size1 - This might not be correct
    * [ModuleDecouple]
      * [isOmniDecoupler] = false
    * [ModuleToggleCrossfeed]
    * [ModuleTestSubject]

### Compatibility

* Rename Patches --> Compatibility
* Headers/Footers
* adjust :NEEDS
* adjust :FOR
* linting
* [RPM.cfg] --> [RasterPropMonitor.cfg]  v1.0.0.0
* [ODFC.cfg] -- [OnDemandFuelCells.cfg]  v1.0.1.0
* [FAR-NEAR.cfg] -- [FerramAerospaceResearch.cfg] v1.0.0.0
* Create
  * thank you @FuryFire2004
    * [MechJeb.cfg] v1.0.0.0
    * [HullCamVDS.cfg] v1.0.0.0
    * [ConnectedLivingSpace.cfg] v1.0.0.0
  * [FireSpitter.cfg] v1.0.0.0
* closes #56 - [Request]: patch for HullCameraVDS
* closes #57 - [Request]: patch for ConnectedLivingSpaces (CLS)
* closes #58 - [Request]: patch for MechJeb (MJ)
* closes #61 - [Request]: patch for FireSpitter (FS)

Co-Authored-By: artwhaley <[email protected]>
@zer0Kerbal zer0Kerbal mentioned this issue Mar 21, 2022
Merged
zer0Kerbal added a commit that referenced this issue Mar 21, 2022
@zer0Kerbal
Merge pull request #45 from zer0Kerbal/Localization
93c799b 
# Passes on parts 

* to remove duplicates
* localize parts and agent
### Localization

* [Agents.cfg]
  * update
  * localize
* closes #11 - Localization - English (United States) <en-us.cfg>
* updates #10 - Localization - Master

### Parts

* Stage I
  * combine multiple versions into one
* [tag] --> [tags]
* [drm-atlas-inter.cfg]
  * [category] 
  * [vesselType]
* [drm-cabin-bay.cfg]
  * [mass] was 0.7, now 2.0
  * [maxTemp] now 3400, was 4400
* [drm-cabin-nobay.cfg]
* [drm-decoupler.cfg]
  * Update
    * [category] was Structural, now is Coupling
    * [maximum_drag] was = 0.02, now is 0.2
    * [minimum_drag] was = 0.0, now is 0.2
    * [angularDrag] was = 1, now is 2
    * [crashTolerance] = 6, was 15
    * [breakingForce] = 150, was 20000
    * [breakingTorque] = 150, was 20000
    * [maxTemp] = 2000, was 3400
    * [mass] = 0.05, was 0.1]
  * Add
    * [bulkheadProfiles] = size1 - This might not be correct
    * [ModuleDecouple]
      * [isOmniDecoupler] = false
    * [ModuleToggleCrossfeed]
    * [ModuleTestSubject]

### Compatibility

* Rename Patches --> Compatibility
* Headers/Footers
* adjust :NEEDS
* adjust :FOR
* linting
* [RPM.cfg] --> [RasterPropMonitor.cfg]  v1.0.0.0
* [ODFC.cfg] -- [OnDemandFuelCells.cfg]  v1.0.1.0
* [FAR-NEAR.cfg] -- [FerramAerospaceResearch.cfg] v1.0.0.0
* Create
  * thank you @FuryFire2004
    * [MechJeb.cfg] v1.0.0.0
    * [HullCamVDS.cfg] v1.0.0.0
    * [ConnectedLivingSpace.cfg] v1.0.0.0
  * [FireSpitter.cfg] v1.0.0.0
* closes #56 - [Request]: patch for HullCameraVDS
* closes #57 - [Request]: patch for ConnectedLivingSpaces (CLS)
* closes #58 - [Request]: patch for MechJeb (MJ)
* closes #61 - [Request]: patch for FireSpitter (FS)
@settings settings bot removed this from the 1.3.99.0-adoption milestone Feb 4, 2023
@zer0Kerbal zer0Kerbal mentioned this issue Feb 10, 2023
Merged
8 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@zer0Kerbal zer0Kerbal

Labels
type: discussion Questions, queries, posers, proposals and info that requires discussion. type: request Requested functionality, features, pages, workflows, endpoints, etc.
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Create mechjeb patch
1.3.99.0 adoption zer0Kerbal/Dreamer
2 participants
@FuryFire2004 @zer0Kerbal