-
Notifications
You must be signed in to change notification settings - Fork 35
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Rename "action" handler to "onClickOutside" #47
Rename "action" handler to "onClickOutside" #47
Conversation
Great work, almost clicked the merge button! :) But then it hit me if you could camelcase |
@zeppelin Totally agree! Will do that today :) |
@zeppelin Sorry, I've not yet managed to pick it up, but it's not forgotten! |
@AndreJoaquim no worries, we're not in a hurry ;) |
hey guys, did you consider using I think it may serve its purpose in this case. |
- Deprecate `except-selector` in favor of `exceptSelector` - Update how `action` deprecation is handled
@AndreJoaquim I've deprecated Thank you for the great contribution! Next up: element modifiers :) |
@zeppelin Cool! |
Closes #45.
I've decided to supersede
onClickOutside
. This means that ifonClickOutside
is passed,action
is ignored. If both are passed, onlyonClickOutside
is called. If onlyaction
is passed, onlyaction
is called.I've added two deprecation warnings:
onClickOutside
andaction
handlers are passed and are functions, it warns that onlyonClickOutside
should be definedaction
handler is passed, it warns that it's deprecated andonClickOutside
should be used insteadI've added and adapted the test suite to include the new behaviours, as well as adapting the README.md