Add Access Point (AP) mode support to siwx91x wifi driver #85906

ArunmaniAlagarsamy2710 · 2025-02-18T06:03:01Z

Implemented support for Wi-Fi Access Point (AP) mode.
Added support for AP-related Wi-Fi commands.
Basic functionalities are included; further enhancements will be added in future PR.

jerome-pouiller · 2025-02-18T08:41:40Z

drivers/wifi/siwx91x/siwx91x_wifi.c

+		return SL_WIFI_BANDWIDTH_80MHz;
+	default:
+		LOG_ERR("Invalid bandwidth");
+		return -EAGAIN;


Probably -EINVAL is better suited.

I am not sure LOG_ERR() is useful (in fact, I don't know what policy we should have for the the logs).

jerome-pouiller · 2025-02-18T08:45:52Z

drivers/wifi/siwx91x/siwx91x_wifi.h

@@ -14,6 +14,8 @@
 #include "sl_si91x_types.h"
 #include "sl_si91x_protocol_types.h"

+#define SIWX91X_INTERFACE_MASK (0x03)


For now, SIWX91X_INTERFACE_MASK is only used in siwx91x_wifi.c. I am not sure it make sense to expose it in the header file.

jerome-pouiller · 2025-02-18T09:01:31Z

drivers/wifi/siwx91x/siwx91x_wifi.c

-	status = sl_wifi_get_mac_address(SL_WIFI_CLIENT_INTERFACE, &sidev->macaddr);
+	interface = sl_wifi_get_default_interface();
+	status = sl_wifi_get_mac_address(FIELD_GET(SIWX91X_INTERFACE_MASK, interface),
+					 &sidev->macaddr);


In what case the original code didn't work?

jerome-pouiller · 2025-02-18T09:04:27Z

drivers/wifi/siwx91x/siwx91x_wifi.c

+		}
+	}
+
+	ret = sl_wifi_start_ap(SL_WIFI_AP_2_4GHZ_INTERFACE, &configuration);


For the reader, it difficult to understand SL_WIFI_AP_2_4GHZ_INTERFACE == SL_WIFI_AP_INTERFACE | SL_WIFI_2_4GHZ_INTERFACE. I suggest either:

Replace references to SL_WIFI_AP_INTERFACE by FIELD_GET(SIWX91X_INTERFACE_MASK, SL_WIFI_AP_2_4GHZ_INTERFACE)

Replace reference to SL_WIFI_AP_2_4GHZ_INTERFACE by SL_WIFI_AP_INTERFACE | SL_WIFI_2_4GHZ_INTERFACE

jerome-pouiller · 2025-02-18T09:08:41Z

drivers/wifi/siwx91x/siwx91x_wifi.c

+
+	if (params->security != WIFI_SECURITY_TYPE_NONE) {
+		ret = sl_net_set_credential(configuration.credential_id, SL_NET_WIFI_PSK,
+					    params->psk, params->psk_length);


default_wifi_ap_credential.type == SL_NET_WIFI_PSK and credentials seems ignored when configuration.security == SL_WIFI_OPEN. So I think you can call this function unconditionally.

jerome-pouiller · 2025-02-18T09:17:30Z

drivers/wifi/siwx91x/siwx91x_wifi.c

+		}
+
+		sl_si91x_set_join_configuration(SL_WIFI_AP_INTERFACE,
+						SL_SI91X_JOIN_FEAT_MFP_CAPABLE_REQUIRED);


I think MFP is orthogonal to the authentication scheme. Probably this configuration should done outside of this switch case.

BTW, WPA2-PSK w/o MFP seems legit. Is it a limitation of Wiseconnect?

I also assume configuration.security = SL_WIFI_WPA3 automatically enables MFP? If ye, we could check params->mfp == WIFI_MFP_REQUIRED.

jerome-pouiller · 2025-02-18T09:18:18Z

drivers/wifi/siwx91x/siwx91x_wifi.c

 #include "sl_wifi.h"
 #include "sl_net.h"

+#define SIWX91X_INTERFACE_MASK (0x03)
+
 LOG_MODULE_REGISTER(siwx91x_wifi);


Keep LOG_MODULE_REGISTER() just after the includes list.

jerome-pouiller · 2025-02-18T09:42:22Z

drivers/wifi/siwx91x/siwx91x_wifi.c

+	strncpy(status->ssid, wlan_info.ssid, WIFI_SSID_MAX_LEN);
+	status->ssid_len = strlen(status->ssid);
+	memcpy(status->bssid, wlan_info.mac_address, WIFI_MAC_ADDR_LEN);
+	status->mfp = WIFI_MFP_REQUIRED;


How can you be sure?

jerome-pouiller · 2025-02-18T09:45:55Z

drivers/wifi/siwx91x/siwx91x_wifi.c

+	memcpy(status->bssid, wlan_info.mac_address, WIFI_MAC_ADDR_LEN);
+	status->mfp = WIFI_MFP_REQUIRED;
+
+	if (FIELD_GET(SL_WIFI_2_4GHZ_INTERFACE, interface)) {


SL_WIFI_2_4GHZ_INTERFACE is not a mask. I would either write:

FIELD_GET(SIWX91X_BAND_MASK, interface) == 1

interface & SL_WIFI_2_4GHZ_INTERFACE

jerome-pouiller · 2025-02-18T09:47:25Z

drivers/wifi/siwx91x/siwx91x_wifi.c

+		status->band = WIFI_FREQ_BAND_2_4_GHZ;
+	}
+
+	if (FIELD_GET(SL_WIFI_CLIENT_INTERFACE, interface)) {


SL_WIFI_CLIENT_INTERFACE is not a mask. I suggest FIELD_GET(SIWX91X_INTERFACE_MASK, interface) == SL_WIFI_CLIENT_INTERFACE.

jerome-pouiller · 2025-02-18T09:49:11Z

drivers/wifi/siwx91x/siwx91x_wifi.c

+
+		sl_wifi_get_listen_interval(SL_WIFI_CLIENT_INTERFACE, &listen_interval);
+		status->beacon_interval = listen_interval.listen_interval;
+	} else if (FIELD_GET(SL_WIFI_AP_INTERFACE, interface)) {


Can this condition be true? oper_mode is always SL_SI91X_CLIENT_MODE. So, I think interface never set SL_WIFI_AP_INTERFACE.

We have added the support to change oper_mode at runtime #85919

I believe #85919 should be a part of this current PR.

jerome-pouiller · 2025-02-18T09:50:23Z

drivers/wifi/siwx91x/siwx91x_wifi.c

+		sl_wifi_get_listen_interval(SL_WIFI_CLIENT_INTERFACE, &listen_interval);
+		status->beacon_interval = listen_interval.listen_interval;
+	} else if (FIELD_GET(SL_WIFI_AP_INTERFACE, interface)) {
+		sl_wifi_ap_configuration_t conf = { };


ap_cfg or sl_ap_cfg or siwx91x_ap_cfg.

This commit introduces Access Point (AP) mode support It enables the following AP-related commands: - ap enable: Enable the AP mode. - ap disable: Disable the AP mode. Signed-off-by: Arunmani Alagarsamy <[email protected]>

This commit adds support the following wifi commands: - wifi ap disconnect: Disconnect a specific station from the AP. - wifi ap stations: List connected devices. Signed-off-by: Arunmani Alagarsamy <[email protected]>

This commit adds support for Wi-Fi status and statistics functionalities: - wifi status : Displays the current mode status. - wifi statistics : Provides details on the transmitted and received packet counts. Signed-off-by: Arunmani Alagarsamy <[email protected]>

This commit enables the device to change its operating mode at runtime by using the wifi command. Signed-off-by: Arunmani Alagarsamy <[email protected]>

jerome-pouiller

The 3 first commits depend on drivers: wifi: siwx91x: Add run time opermode, so you have place it first.

jerome-pouiller · 2025-02-19T09:45:23Z

drivers/wifi/siwx91x/siwx91x_wifi.c

+						  SL_SI91X_TCP_IP_FEAT_BYPASS),
+			.custom_feature_bit_map = SL_SI91X_CUSTOM_FEAT_EXTENSION_VALID,
+			.feature_bit_map = SL_SI91X_FEAT_SECURITY_OPEN,
+			.coex_mode = SL_SI91X_WLAN_ONLY_MODE,


How do you deal with BLE?

I feel this function is in fact shared with Bluetooth and event with Flash driver. Probably it should be located in soc/silabs/silabs_siwx91x/siwg917/nwp_init.c.

zephyrbot added the area: Wi-Fi Wi-Fi label Feb 18, 2025

zephyrbot requested review from jukkar, Kludentwo, krish2718, MaochenWang1 and rlubos February 18, 2025 06:03

zephyrbot assigned jukkar Feb 18, 2025

ArunmaniAlagarsamy2710 force-pushed the driver/access_point branch from 5add5e0 to d02f00a Compare February 18, 2025 07:20

jerome-pouiller self-requested a review February 18, 2025 08:40

jerome-pouiller reviewed Feb 18, 2025

View reviewed changes

ArunmaniAlagarsamy2710 force-pushed the driver/access_point branch from d02f00a to d610343 Compare February 18, 2025 08:54

jerome-pouiller reviewed Feb 18, 2025

View reviewed changes

ArunmaniAlagarsamy2710 force-pushed the driver/access_point branch from d610343 to 768343b Compare February 18, 2025 15:54

ArunmaniAlagarsamy2710 mentioned this pull request Feb 18, 2025

drivers: wifi: siwx91x: Add run time opermode #85919

Closed

ArunmaniAlagarsamy2710 force-pushed the driver/access_point branch from 768343b to d5c66f1 Compare February 18, 2025 15:56

ArunmaniAlagarsamy2710 mentioned this pull request Feb 18, 2025

Add AP mode support and error propagation improvements SiliconLabsSoftware/zephyr-silabs#87

Closed

ArunmaniAlagarsamy2710 added 3 commits February 19, 2025 10:17

drivers: wifi: siwx91x: Add Access Point (AP) mode support

7a562d2

This commit introduces Access Point (AP) mode support It enables the following AP-related commands: - ap enable: Enable the AP mode. - ap disable: Disable the AP mode. Signed-off-by: Arunmani Alagarsamy <[email protected]>

drivers: wifi: siwx91x: Add AP station disconnect functionality

8e545ad

This commit adds support the following wifi commands: - wifi ap disconnect: Disconnect a specific station from the AP. - wifi ap stations: List connected devices. Signed-off-by: Arunmani Alagarsamy <[email protected]>

ArunmaniAlagarsamy2710 force-pushed the driver/access_point branch from d5c66f1 to acff2d2 Compare February 19, 2025 04:48

drivers: wifi: siwx91x: Add run time opermode

d5d3c31

This commit enables the device to change its operating mode at runtime by using the wifi command. Signed-off-by: Arunmani Alagarsamy <[email protected]>

ArunmaniAlagarsamy2710 force-pushed the driver/access_point branch from acff2d2 to d5d3c31 Compare February 19, 2025 05:03

jerome-pouiller reviewed Feb 19, 2025

View reviewed changes

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Add Access Point (AP) mode support to siwx91x wifi driver #85906

Add Access Point (AP) mode support to siwx91x wifi driver #85906

ArunmaniAlagarsamy2710 commented Feb 18, 2025

jerome-pouiller Feb 18, 2025 •

edited

Loading

jerome-pouiller Feb 18, 2025

jerome-pouiller Feb 18, 2025

jerome-pouiller Feb 18, 2025

jerome-pouiller Feb 18, 2025

jerome-pouiller Feb 18, 2025

jerome-pouiller Feb 18, 2025

jerome-pouiller Feb 18, 2025

jerome-pouiller Feb 18, 2025

jerome-pouiller Feb 18, 2025

jerome-pouiller Feb 18, 2025

ArunmaniAlagarsamy2710 Feb 18, 2025

jerome-pouiller Feb 18, 2025

jerome-pouiller Feb 18, 2025

jerome-pouiller left a comment

jerome-pouiller Feb 19, 2025

Add Access Point (AP) mode support to siwx91x wifi driver #85906

Are you sure you want to change the base?

Add Access Point (AP) mode support to siwx91x wifi driver #85906

Conversation

ArunmaniAlagarsamy2710 commented Feb 18, 2025

jerome-pouiller Feb 18, 2025 • edited Loading

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

jerome-pouiller left a comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

jerome-pouiller Feb 18, 2025 •

edited

Loading