Add support for NXP S32K148 evaluation board

[marcin-wierzbicki]

Add support for NXP S32K148 evaluation board.

The board can be debugged using gdb (see boards/nxp/s32k148_evb/doc/index.rst).
The board cannot be debugged using the west debug command, since pyOCD does not support the target. I would be grateful for any guidance on this.

Adapt samples: adc_dt, adc_sequence.
Adapt tests: adc_api, gpio_basic_api, gpio_hogs.

See Add support for S32K148 SoC

[manuargue]

See zephyrproject-rtos/hal_nxp#509

@marcin-wierzbicki please update the hal_nxp entry in the west manifest to point to that pr

[manuargue]

Add driver for TJA1101 PHY device.

I'd recommend to keep this first PR smaller including basic enablement of the SoC and board, and split the PHY driver into another PR for easier review. This will likely also help you to move the prs faster. This is not mandatory, but in general a good practice.

[marcin-wierzbicki]

Add driver for TJA1101 PHY device.

I'd recommend to keep this first PR smaller including basic enablement of the SoC and board, and split the PHY driver into another PR for easier review. This will likely also help you to move the prs faster. This is not mandatory, but in general a good practice.

Sure. Thank you.

[zephyrbot]

The following west manifest projects have changed revision in this Pull Request:

Name	Old Revision	New Revision	Diff
hal_nxp	zephyrproject-rtos/hal_nxp@2a1d73a	❌ Impostor SHA: zephyrproject-rtos/hal_nxp@757c89a	zephyrproject-rtos/[email protected]

⛔ DNM label due to: 1 impostor SHA

Note: This message is automatically posted and updated by the Manifest GitHub Action.

[nordicjm]

@marcin-wierzbicki you have marked multiple comments I left as resolved, they aren't resolved, you haven't fixed the issues, please acquaint yourself with the contributor guidelines https://docs.zephyrproject.org/latest/contribute/contributor_expectations.html#workflow-suggestions-that-help-reviewers as per

Unless they applied the reviewer’s recommendation exactly, authors must not resolve and hide comments, they must let the initial reviewer do it. The Zephyr project does not require all comments to be resolved before merge. Leaving some completed discussions open can sometimes be useful to understand the greater picture.

Also apply the coding style requirements to this PR without saying "will be handled in future"

[marcin-wierzbicki]

@marcin-wierzbicki you have marked multiple comments I left as resolved, they aren't resolved, you haven't fixed the issues, please acquaint yourself with the contributor guidelines https://docs.zephyrproject.org/latest/contribute/contributor_expectations.html#workflow-suggestions-that-help-reviewers as per

Unless they applied the reviewer’s recommendation exactly, authors must not resolve and hide comments, they must let the initial reviewer do it. The Zephyr project does not require all comments to be resolved before merge. Leaving some completed discussions open can sometimes be useful to understand the greater picture.

Also apply the coding style requirements to this PR without saying "will be handled in future"

Thank you for the feedback! The coding style fixes are already being addressed in a separate branch, and @KevShaju will be submitting a dedicated PR for them soon. This will help keep this PR focused on its main changes while ensuring consistency across the project.

[maass-hamburg]

@marcin-wierzbicki you have marked multiple comments I left as resolved, they aren't resolved, you haven't fixed the issues, please acquaint yourself with the contributor guidelines https://docs.zephyrproject.org/latest/contribute/contributor_expectations.html#workflow-suggestions-that-help-reviewers as per

Unless they applied the reviewer’s recommendation exactly, authors must not resolve and hide comments, they must let the initial reviewer do it. The Zephyr project does not require all comments to be resolved before merge. Leaving some completed discussions open can sometimes be useful to understand the greater picture.

Also apply the coding style requirements to this PR without saying "will be handled in future"

Thank you for the feedback! The coding style fixes are already being addressed in a separate branch, and @KevShaju will be submitting a dedicated PR for them soon. This will help keep this PR focused on its main changes while ensuring consistency across the project.

This PR will not be approved and merged, if the requested changes are not done.

[marcin-wierzbicki]

@marcin-wierzbicki you have marked multiple comments I left as resolved, they aren't resolved, you haven't fixed the issues, please acquaint yourself with the contributor guidelines https://docs.zephyrproject.org/latest/contribute/contributor_expectations.html#workflow-suggestions-that-help-reviewers as per

Unless they applied the reviewer’s recommendation exactly, authors must not resolve and hide comments, they must let the initial reviewer do it. The Zephyr project does not require all comments to be resolved before merge. Leaving some completed discussions open can sometimes be useful to understand the greater picture.

Also apply the coding style requirements to this PR without saying "will be handled in future"

Thank you for the feedback! The coding style fixes are already being addressed in a separate branch, and @KevShaju will be submitting a dedicated PR for them soon. This will help keep this PR focused on its main changes while ensuring consistency across the project.

This PR will not be approved and merged, if the requested changes are not done.

Thank you. We have addressed all the requested changes in this PR.

[manuargue]

adding west runner support should be straight forward, e.g.

• jlink: https://github.com/zephyrproject-rtos/zephyr/blob/main/boards/nxp/ucans32k1sic/board.cmake#L4-L9
• or, s32 debug probe: https://github.com/zephyrproject-rtos/zephyr/blob/main/boards/nxp/s32z2xxdc2/board.cmake#L10-L13

No need to comment on pyOCD if it's not supported for this target (only on what is supported).

[marcin-wierzbicki]

Thanks for the input. Regarding the nxp_s32dbg runner, I believe nxp_s32dbg.py won’t work for the S32K148 as-is. There are some hardcoded elements, and it currently runs the gta process, whereas in this case, we need to use pegdbserver_console. It might be necessary to introduce a new runner to support this properly