arch: arm: support for KW2xD SiP and USB-KW24D512 #845

jfischer-no · 2017-07-19T16:45:56Z

add KW2XD SiP support
add USB-KW24D512 support

galak

There are a bunch of k64 references that need cleaning up.

galak · 2017-07-19T16:52:34Z

dts/arm/nxp/nxp_kw2xd.dtsi

+
+/ {
+	cpus {
+		cpu@0 {


Update CPU node to match recent PR #809

galak · 2017-07-19T16:54:08Z

dts/arm/nxp/nxp_kw2xd.dtsi

+	};
+
+	soc {
+


add in I2C nodes - see PR #755

galak · 2017-07-19T16:54:25Z

dts/arm/nxp/nxp_kw2xd.dtsi

+
+	soc {
+
+		mcg: clock-controller@40064000 {


Add ADC nodes - see PR #804

galak · 2017-07-19T16:56:00Z

arch/arm/soc/nxp_kinetis/kw2xd/soc.h

+
+/* address bases */
+
+#define PERIPH_ADDR_BASE_MPU 0x4000D000 /* Memory Protection Unit */


all these PERIPH_* defines aren't needed.

dbkinder · 2017-07-19T17:23:45Z

boards/arm/usb_kw24d512/doc/usb_kw24d512.rst

+The USB-KW24D512 board is an IEEE 802.15.4 packet sniffer in a
+convenient USB dongle form factor.
+
+- Packet sniffers are essential for wireless network development allowing


This would read better just as regular sentences (with the previous one) rather than two bullet points.

dbkinder · 2017-07-19T17:27:43Z

boards/arm/usb_kw24d512/doc/usb_kw24d512.rst

+
+The KW2xD SoC has six UARTs. One is configured and can be used for the console,
+the remaining are not used.
+


You're missing the "Programming and Debugging" section (with Flashing and Debugging information) listed in the board doc template (doc/templates/board.tmpl). Can you include something about this?

I have left it consciously 😄. KW24D512 is functional equal to the KW22D512, KW22D512 is supported by OpenOCD and for the KW24D512 I have a 3 lines patch. Phytec has the similar hardware, but with the KW22D512. And it is possible to flash it with jlink, so it would be a little longer chapter. Currently I do not know how I describe it best, so I would like to do it later.

I have added the "Programming and Debugging" section in ad382b7

dbkinder · 2017-07-19T17:36:53Z

boards/arm/usb_kw24d512/doc/usb_kw24d512.rst

+- Integrated PCB Folded F-type antenna
+- Cortex 10-pin (0.05”) JTAG debug port for target MCU
+
+For more information about the KW2xD SiP and USB-KW24D512 board:


suggest spelling out SiP in this first use:

KW2xD System-in-Package (SiP)

dbkinder

some doc suggestions and ask for programming details found in the board.tmpl template.

MaureenHelm

Generally looks pretty good, just one question regarding soc series and a couple of minor edits. Could you please also update ext/hal/nxp/mcux/README

MaureenHelm · 2017-07-19T19:42:30Z

arch/arm/soc/nxp_kinetis/kw2xd/Kconfig.defconfig.mkw2xd512

+
+if SPI
+
+config SPI_MCUX


This should be SPI_MCUX_DSPI

MaureenHelm · 2017-07-19T19:46:27Z

arch/arm/soc/nxp_kinetis/kw2xd/Kconfig.defconfig.mkw2xd512

+
+if RANDOM_GENERATOR
+
+config RANDOM_MCUX


This should be RANDOM_MCUX_RNGA

MaureenHelm · 2017-07-19T19:53:49Z

arch/arm/soc/nxp_kinetis/kw2xd/Kconfig.defconfig.mkw2xd512

+
+config SOC
+	string
+	default mkw22d5


This should be different for KW22 and KW24. It's used to select which device header files get included from mcux. See ext/hal/nxp/mcux/Makefile

MaureenHelm · 2017-07-19T20:01:51Z

arch/arm/soc/nxp_kinetis/kw2xd/Kconfig.series

+# SPDX-License-Identifier: Apache-2.0
+#
+
+config SOC_SERIES_KINETIS_KW2XD


My original intent when I added KW41Z was that KW2xD would be part of the same series (e.g., the Kinetis W-series). That's why I didn't select a specific Cortex M core (M0+ vs. M4) with SOC_SERIES_KINETIS_KWX. Your thoughts on merging kw2xd into kwx series?

I thought about it, but then I was not sure, I look at it.

Please review 7c4c1dc

MaureenHelm · 2017-07-19T20:02:27Z

arch/arm/soc/nxp_kinetis/kw2xd/Kconfig.soc

@@ -0,0 +1,77 @@
+# Kconfig - Kinetis K6X MCU line
+#
+# Copyright (c) 2016 Open-RnD Sp. z o.o.


Update the header

MaureenHelm · 2017-07-19T20:11:51Z

dts/arm/nxp/nxp_kw2xd.dtsi

+			status = "disabled";
+		};
+
+		uart3: uart@4006d000 {


This instance doesn't exist

MaureenHelm · 2017-07-19T20:18:16Z

boards/arm/usb_kw24d512/Makefile.board

@@ -0,0 +1,7 @@
+FLASH_SCRIPT = openocd.sh
+DEBUG_SCRIPT = openocd.sh


Does OpenOCD support this part upstream? I don't know offhand. Can you add jlink support?

OpenOCD supports KW21D and KW22D512 devices. As far as I know none uses the KW24D5 😄, it has the same functionality as KW22D5, but a different ID. For the KW24D5 I quickly made a patch (https://github.com/jfischer-phytec-iot/openocd/commit/2ec86a443d452135b5c2a1711f99f3dd423397f5). I do not have a jlink, we have built the similar device with KW22D512 and we use the mbed firmware for our debuggers and kits.

You should be able to swap the mbed firmware with the jlink firmware.

Can you please add a link to your OpenOCD patch in the board doc?

MaureenHelm · 2017-07-19T20:20:05Z

boards/arm/usb_kw24d512/doc/usb_kw24d512.rst

+Serial Port
+===========
+
+The KW2xD SoC has six UARTs. One is configured and can be used for the console,


s/six/three/

MaureenHelm · 2017-07-21T15:11:52Z

arch/arm/soc/nxp_kinetis/kwx/Kconfig.soc

@@ -43,14 +59,58 @@ config SOC_PART_NUMBER_MKW41Z256VHT4
 config SOC_PART_NUMBER_MKW41Z512VHT4
 	bool

+config SOC_PART_NUMBER_MKW22D512VHA5


nit: Could you please move these new lines above the KW40 so they're in numerical order?

MaureenHelm · 2017-07-21T15:12:21Z

arch/arm/soc/nxp_kinetis/kwx/Kconfig.soc

 config SOC_PART_NUMBER_KINETIS_KWX
 	string
 	default "MKW40Z160VHT4" if SOC_PART_NUMBER_MKW40Z160VHT4
 	default "MKW41Z256VHT4" if SOC_PART_NUMBER_MKW41Z256VHT4
 	default "MKW41Z512VHT4" if SOC_PART_NUMBER_MKW41Z512VHT4
+	default "MKW22D512VHA5" if SOC_PART_NUMBER_MKW22D512VHA5
+	default "MKW24D512VHA5" if SOC_PART_NUMBER_MKW24D512VHA5


Please move these before the KW40

MaureenHelm · 2017-07-21T15:14:57Z

arch/arm/soc/nxp_kinetis/kwx/Makefile

+obj-$(CONFIG_SOC_MKW24D5) += wdog.o soc_kw2xd.o
+obj-$(CONFIG_SOC_MKW22D5) += wdog.o soc_kw2xd.o
+obj-$(CONFIG_SOC_MKW41Z4) += soc_kw4xz.o
+obj-$(CONFIG_SOC_MKW40Z4) += soc_kw4xz.o


I think eventually we should try to unify these into one soc.c file, but it's fine to have them separate for now. I'm planning to work on a more general MCG clock driver soon that should help.

MaureenHelm · 2017-07-21T15:19:29Z

arch/arm/soc/nxp_kinetis/kwx/soc_kw2xd.c

+	PORTB->PCR[19] = (PORTB->PCR[19] & ~PORT_PCR_MUX_MASK) |
+			 PORT_PCR_MUX(0x01u);
+	/* PORTC.0 as GPIO */
+	PORTC->PCR[0] = (PORTC->PCR[0] & ~PORT_PCR_MUX_MASK) |


Can we move this to the board pinmux.c file? I like to have all the pinmuxing in one place because it will be a lot more obvious if there's a conflict.

Is not possible since kw2xd_init is called before phynode_kw22d5_pinmux_init (*_INIT_PRIORITY 0 vs. 45). The part with the modem clock is not so nice, but it works so far everything right. I have successfully tested it with the MCR20A driver. Driver only needs to be modified so that it does not reinitialize MCR20A. USB driver also works so far.

I will describe set_modem_clock better.

This is board specific, so why not move this to the board code and do something like:

clkInit(void)
{
CLOCK_SetSimSafeDivs();

early_board_clkInit();

...
}

__weak early_board_clkInit(void)
{
return;
}

It is not really board specific, if CLK_OUT from the transceiver is the clock source for the PLL, it will look the same for all boards (these pins are internally connected, not on the board)

MaureenHelm · 2017-07-21T15:23:36Z

boards/arm/usb_kw24d512/Kconfig.defconfig

+	default usb_kw24d512
+
+config OSC_XTAL0_FREQ
+	default 4000000


This should be 32 MHz

When the modem is initialized like in set_modem_clock, it is 4MHz (Table 5-10, CLOCK_OUT ist 4MHz if GPIO5=0 after reset, GPIO5 is connected to PTC0, CLOCK_OUT to EXTAL0)

Ok. Can you please add a comment here so we remember that we're not using the board crystal?

MaureenHelm · 2017-07-21T15:30:43Z

boards/arm/usb_kw24d512/Makefile.board

@@ -0,0 +1,7 @@
+FLASH_SCRIPT = openocd.sh
+DEBUG_SCRIPT = openocd.sh


You should be able to swap the mbed firmware with the jlink firmware.

Can you please add a link to your OpenOCD patch in the board doc?

MaureenHelm · 2017-07-21T15:42:03Z

boards/arm/usb_kw24d512/usb_kw24d512_defconfig

+CONFIG_BOARD_USB_KW24D512=y
+CONFIG_CONSOLE=y
+CONFIG_UART_CONSOLE=y
+CONFIG_UART_CONSOLE_ON_DEV_NAME="UART_0"


This should come from dts instead

I've changed it and just added J-Link support. Once the support for kw24d5 is in pyOCD or OpenOCD mainline, I will expand the docu.

MaureenHelm · 2017-07-27T14:44:41Z

arch/arm/soc/nxp_kinetis/kwx/soc_kw2xd.c

+	PORTB->PCR[19] = (PORTB->PCR[19] & ~PORT_PCR_MUX_MASK) |
+			 PORT_PCR_MUX(0x01u);
+	/* PORTC.0 as GPIO */
+	PORTC->PCR[0] = (PORTC->PCR[0] & ~PORT_PCR_MUX_MASK) |


MaureenHelm · 2017-07-27T14:49:11Z

arch/arm/soc/nxp_kinetis/kwx/soc.h

+#define IRQ_UART1_STATUS 33
+#define IRQ_UART1_ERROR 34
+#define IRQ_UART2_STATUS 35
+#define IRQ_UART2_ERROR 36


Remove the UART IRQs. See #899

MaureenHelm · 2017-07-27T14:54:42Z

boards/arm/usb_kw24d512/Kconfig.board

+#
+
+config BOARD_USB_KW24D512
+	bool "Freescale USB-KW24D512"


s/Freescale/NXP/

MaureenHelm · 2017-07-27T14:57:09Z

boards/arm/usb_kw24d512/Kconfig.defconfig

+	default usb_kw24d512
+
+config OSC_XTAL0_FREQ
+	default 4000000


Ok. Can you please add a comment here so we remember that we're not using the board crystal?

MaureenHelm · 2017-07-27T15:16:24Z

boards/arm/usb_kw24d512/doc/usb_kw24d512.rst

+Serial Port
+===========
+
+The KW2xD SoC has tree UARTs. One is configured and can be used for the console,


s/tree/three/

MaureenHelm · 2017-07-27T15:17:56Z

boards/arm/usb_kw24d512/doc/usb_kw24d512.rst

+   $ cd <zephyr_root_path>
+   $ . zephyr-env.sh
+   $ cd samples/hello_world/
+   $ make BOARD=usb_kw24d512 DEBUG_SCRIPT=jlink.sh debug


You can remove DEBUG_SCRIPT=jlink.sh since it's the default

galak

Some DT updates/changes.

galak · 2017-08-03T13:24:34Z

dts/arm/nxp/nxp_kw2xd.dtsi

+		};
+	};
+
+	sram0: memory {


sram0: memory@20000000

galak · 2017-08-03T13:24:45Z

dts/arm/nxp/nxp_kw2xd.dtsi

+	};
+
+	sram0: memory {
+		compatible = "mmio-sram";


device_type = "memory";

galak · 2017-08-03T13:30:34Z

dts/arm/nxp/nxp_kw2xd.dtsi

+		};
+
+		pwm1: pwm@40039000{
+			compatible = "nxp,k64f-pwm";


lets go ahead and rename the compatible to:
compatible = "nxp,kinetis-ftm";

galak · 2017-08-03T13:31:11Z

dts/arm/nxp/nxp_kw2xd.dtsi

+			compatible = "nxp,k64f-pwm";
+			reg = <0x40039000 0x98>;
+			prescaler = <2>;
+			period = <1000>;


lets remove prescaler, period, & clock-source

dbkinder · 2017-08-03T18:41:03Z

boards/arm/usb_kw24d512/doc/usb_kw24d512.rst

+
+In a second terminal, open telnet:
+
+  .. code-block:: console


The .. code-block shouldn't be indented

dbkinder · 2017-08-03T18:41:28Z

boards/arm/usb_kw24d512/doc/usb_kw24d512.rst

+
+Continue program execution in GDB, then in the telnet terminal you should see:
+
+  .. code-block:: console


same here... don't indent the .. code-block

dbkinder

formatting fix requested (.. code-block shouldn't be indented)

jfischer-no · 2017-08-08T09:11:44Z

@dbkinder @galak @MaureenHelm please review changes

galak · 2017-08-09T15:20:57Z

boards/arm/usb_kw24d512/usb_kw24d512.yaml

+  - zephyr
+  - gccarmemb
+supported:
+  - ieee802154


need to add:

ram: 32

galak

Can you look at the failures when we do:

./scripts/sanitycheck -p usb_kw24d512

(after adding ram: 32, in usb_kw24d512.yaml) I see:

total complete: 0/ 3 0% failed: 0

usb_kw24d512 samples/nfc/nfc_hello/test FAILED: build_error
see: sanity-out/usb_kw24d512/samples/nfc/nfc_hello/test/build.log

total complete: 1/ 3 33% failed: 1

usb_kw24d512 tests/drivers/build_all/test_build_drivers FAILED: build_error
see: sanity-out/usb_kw24d512/tests/drivers/build_all/test_build_drivers/build.log

total complete: 2/ 3 66% failed: 2

usb_kw24d512 samples/sensor/sx9500/test FAILED: build_error
see: sanity-out/usb_kw24d512/samples/sensor/sx9500/test/build.log

jfischer-no · 2017-08-10T18:04:43Z

Funny, it does not even go through (on Debian testing), I did not try it yet with Zephyr SDK. It fails each time on different test or samples.

Generating LALR tables
Cleaning output directory /home/john/src/zephyr-project/sanity-out
Building testcase defconfigs...
Traceback (most recent call last):
  File "./scripts/sanitycheck", line 2096, in <module>
    main()
  File "./scripts/sanitycheck", line 1991, in main
    args.platform_limit, toolchain, args.extra_args, args.ccache)
  File "./scripts/sanitycheck", line 1407, in apply_filters
    with open(out_config, "r") as fp:
FileNotFoundError: [Errno 2] No such file or directory: '/home/john/src/zephyr-project/sanity-out/usb_kw24d512/tests/net/lib/http_header_fields/test_with_bt/.config-sanitycheck'

galak · 2017-08-10T20:24:05Z

That's a new one for me.

jfischer-no · 2017-08-10T20:33:33Z

It was my environment in the shell, USE_CCACHE=1 was defined.

jfischer-no · 2017-08-10T20:42:28Z

./scripts/sanitycheck -p usb_kw24d512

Generating LALR tables
Cleaning output directory /home/john/src/zephyr-project/sanity-out
Building testcase defconfigs...
104 tests selected, 21805 tests discarded due to filters
total complete:   99/ 104  95%  failed:    0
104 of 104 tests passed with 0 warnings in 452 seconds
Traceback (most recent call last):
  File "./scripts/sanitycheck", line 2096, in <module>
    main()
  File "./scripts/sanitycheck", line 2087, in main
    ts.testcase_report(LAST_SANITY)
  File "./scripts/sanitycheck", line 1712, in testcase_report
    rowdict["ram_size"] = goal.metrics["ram_size"]
KeyError: 'ram_size'

jfischer-no · 2017-08-23T20:30:29Z

@galak any chance to get it in 1.9, I guess not 😄

MaureenHelm · 2017-08-24T21:40:42Z

Needs rebasing, but otherwise LGTM. I tested hello_world and basic/blinky samples on hw. Can you enable at least one of the net samples too?

jfischer-no · 2017-08-25T21:47:30Z

Needs rebasing, but otherwise LGTM. I tested hello_world and basic/blinky samples on hw. Can you enable at least one of the net samples too?

rebased, sample samples/net/ieee802154/hw/ (make BOARD=usb_kw24d512 CONF_FILE=prj_mcr20a.conf debug) can be built and tried out, but the shell does not work with the RTT. If you can get the IP address (sniffer), then you can ping the device 😄.

jfischer-no · 2017-09-13T22:09:19Z

@galak Is there anything that prevents it from being accepted?

galak · 2017-09-13T23:08:57Z

@jfischer-phytec-iot need to look at the sanity failures and decide what to do about them.

MaureenHelm · 2017-09-19T20:01:17Z

@jfischer-phytec-iot need to look at the sanity failures and decide what to do about them.

The problem is that you've enabled default drivers based on the SoC (which is the right thing to do), but not default driver instances based on the board. You can add default uart and i2c instances to the board defconfig to clean up the build warnings in these tests.

jfischer-no · 2017-09-24T14:00:55Z

@galak @MaureenHelm I followed your suggestion also added options for ADC and FTM, needs review

Origin: NXP MCUXpresso KSDK 2.2 URL: https://mcuxpresso.nxp.com/ Maintained-by: External Signed-off-by: Johann Fischer <[email protected]>

Jira: ZEP-1471 Signed-off-by: Johann Fischer <[email protected]>

Jira: ZEP-1472 Signed-off-by: Johann Fischer <[email protected]>

Changes maded

jfischer-no requested a review from dbkinder as a code owner July 19, 2017 16:45

galak assigned galak and MaureenHelm Jul 19, 2017

galak requested a review from MaureenHelm July 19, 2017 16:47

galak requested changes Jul 19, 2017

View reviewed changes

dbkinder reviewed Jul 19, 2017

View reviewed changes

dbkinder suggested changes Jul 19, 2017

View reviewed changes

MaureenHelm previously requested changes Jul 19, 2017

View reviewed changes

jfischer-no mentioned this pull request Jul 19, 2017

drivers: usb: USB device driver for Kinetis USBFSOTG Controller #542

Merged

5 tasks

jfischer-no force-pushed the pr-kw2xd branch 4 times, most recently from 20a1931 to f646570 Compare July 20, 2017 10:29

galak closed this Jul 20, 2017

galak reopened this Jul 20, 2017

MaureenHelm reviewed Jul 21, 2017

View reviewed changes

jfischer-no mentioned this pull request Jul 26, 2017

drivers: mcr20a: minor fixes and adaptions to use with KW2xD devices #931

Merged

jfischer-no force-pushed the pr-kw2xd branch from ad382b7 to a293e7f Compare July 26, 2017 22:42

MaureenHelm reviewed Jul 27, 2017

View reviewed changes

MaureenHelm force-pushed the arm branch from 38db4ed to b4598c1 Compare July 28, 2017 19:55

jfischer-no force-pushed the pr-kw2xd branch from a293e7f to 27c8deb Compare July 29, 2017 10:25

galak requested changes Aug 3, 2017

View reviewed changes

dbkinder reviewed Aug 3, 2017

View reviewed changes

dbkinder suggested changes Aug 3, 2017

View reviewed changes

jfischer-no force-pushed the pr-kw2xd branch from 27c8deb to d47f23a Compare August 3, 2017 23:53

galak force-pushed the arm branch from fce2cc1 to fe0feea Compare August 4, 2017 19:33

galak reviewed Aug 9, 2017

View reviewed changes

boards/arm/usb_kw24d512/usb_kw24d512.yaml

- zephyr

- gccarmemb

supported:

- ieee802154

Copy link

Collaborator

galak Aug 9, 2017

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

need to add:

ram: 32

galak requested changes Aug 9, 2017

View reviewed changes

jfischer-no dismissed dbkinder’s stale review via 36f191f August 10, 2017 20:51

jfischer-no force-pushed the pr-kw2xd branch from d47f23a to 36f191f Compare August 10, 2017 20:51

jfischer-no force-pushed the pr-kw2xd branch from 36f191f to 136d84a Compare August 25, 2017 21:34

galak force-pushed the arm branch from c48d548 to 7714c9a Compare September 13, 2017 15:09

jfischer-no force-pushed the pr-kw2xd branch from 136d84a to 02f2b6d Compare September 13, 2017 21:33

jfischer-no force-pushed the pr-kw2xd branch 2 times, most recently from 6996bf6 to 88a3d1b Compare September 24, 2017 12:08

galak force-pushed the arm branch from 24b32b3 to f0d5097 Compare September 25, 2017 17:34

jfischer-no added 3 commits September 25, 2017 22:36

ext: mcux: import mcux device headers for MKW22D5 and MKW24D5 SiP

b1de42c

Origin: NXP MCUXpresso KSDK 2.2 URL: https://mcuxpresso.nxp.com/ Maintained-by: External Signed-off-by: Johann Fischer <[email protected]>

arch: nxp_kinetis: initial import KW2XD SiP

0f693e7

Jira: ZEP-1471 Signed-off-by: Johann Fischer <[email protected]>

boards: add USB-KW24D512 support

dca154f

Jira: ZEP-1472 Signed-off-by: Johann Fischer <[email protected]>

jfischer-no force-pushed the pr-kw2xd branch from 88a3d1b to dca154f Compare September 25, 2017 20:39

galak approved these changes Sep 26, 2017

View reviewed changes

galak merged commit 0873a14 into zephyrproject-rtos:arm Sep 26, 2017

MaureenHelm mentioned this pull request Oct 16, 2017

Support for NXP KW2xD MCU #2942

Closed

jfischer-no deleted the pr-kw2xd branch May 28, 2018 08:57


		/* address bases */

		#define PERIPH_ADDR_BASE_MPU 0x4000D000 /* Memory Protection Unit */


		The KW2xD SoC has six UARTs. One is configured and can be used for the console,
		the remaining are not used.

		@@ -0,0 +1,7 @@
		FLASH_SCRIPT = openocd.sh
		DEBUG_SCRIPT = openocd.sh


		Continue program execution in GDB, then in the telnet terminal you should see:

		.. code-block:: console

arch: arm: support for KW2xD SiP and USB-KW24D512 #845

arch: arm: support for KW2xD SiP and USB-KW24D512 #845

Conversation

jfischer-no commented Jul 19, 2017

galak left a comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

dbkinder Jul 19, 2017 • edited Loading

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

dbkinder left a comment

Choose a reason for hiding this comment

MaureenHelm left a comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

jfischer-no Jul 22, 2017 • edited Loading

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

galak left a comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

dbkinder left a comment

Choose a reason for hiding this comment

jfischer-no commented Aug 8, 2017

Choose a reason for hiding this comment

galak left a comment • edited Loading

Choose a reason for hiding this comment

jfischer-no commented Aug 10, 2017

galak commented Aug 10, 2017

jfischer-no commented Aug 10, 2017

jfischer-no commented Aug 10, 2017

jfischer-no commented Aug 23, 2017

MaureenHelm commented Aug 24, 2017

jfischer-no commented Aug 25, 2017

jfischer-no commented Sep 13, 2017

galak commented Sep 13, 2017

MaureenHelm commented Sep 19, 2017

jfischer-no commented Sep 24, 2017

dbkinder Jul 19, 2017 •

edited

Loading

jfischer-no Jul 22, 2017 •

edited

Loading

galak left a comment •

edited

Loading