Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

dts: xtensa: Fix gpio-reserved-ranges of esp32_wroom_32ue_n4 #81552

Merged
merged 1 commit into from
Dec 26, 2024

Conversation

Peth-typark
Copy link
Contributor

The range of GPIO37-38 is <5 2>

Signed-off-by: Peth-typark [email protected]

@zephyrbot zephyrbot added area: Xtensa Xtensa Architecture size: XS A PR changing only a single line of code platform: ESP32 Espressif ESP32 labels Nov 19, 2024
Copy link

Hello @Peth-typark, and thank you very much for your first pull request to the Zephyr project!
Our Continuous Integration pipeline will execute a series of checks on your Pull Request commit messages and code, and you are expected to address any failures by updating the PR. Please take a look at our commit message guidelines to find out how to format your commit messages, and at our contribution workflow to understand how to update your Pull Request. If you haven't already, please make sure to review the project's Contributor Expectations and update (by amending and force-pushing the commits) your pull request if necessary.
If you are stuck or need help please join us on Discord and ask your question there. Additionally, you can escalate the review when applicable. 😊

@sylvioalves
Copy link
Collaborator

sylvioalves commented Nov 19, 2024

@Peth-typark, nice catch. Are you able to fix all other ESP32's .dtsi gpio1 gpio-reserved-ranges accordingly? Almost all of them has this wrong value. In case you can't, let me know and I add to this PR. Thanks!

@Peth-typark
Copy link
Contributor Author

Alright. However, the only files I could find are the ones with GPIO range comments, which is the extent of what I can do. I will add the fixes.

@sylvioalves
Copy link
Collaborator

sylvioalves commented Nov 21, 2024

Alright. However, the only files I could find are the ones with GPIO range comments, which is the extent of what I can do. I will add the fixes.

Thanks! Would you mind squashing both commits in a single one?

@Peth-typark
Copy link
Contributor Author

Sure. That sounds good.

@Peth-typark
Copy link
Contributor Author

@sylvioalves, I’ve updated the PR with the fixes for all the files I could find and squashed the commits into one. Please let me know if there’s anything else I need to address or if further changes are required. Thanks!

@kartben
Copy link
Collaborator

kartben commented Dec 19, 2024

@Peth-typark please address compliance issues. Author and sign off entry should be your legal name (First Last)

The range of GPIO37-38 is <5 2>

Signed-off-by: Taeyoun Park <[email protected]>
@kartben
Copy link
Collaborator

kartben commented Dec 26, 2024

@sylvioalves please take a look

@kartben kartben merged commit 9769a39 into zephyrproject-rtos:main Dec 26, 2024
24 checks passed
Copy link

Hi @Peth-typark!
Congratulations on getting your very first Zephyr pull request merged 🎉🥳. This is a fantastic achievement, and we're thrilled to have you as part of our community!

To celebrate this milestone and showcase your contribution, we'd love to award you the Zephyr Technical Contributor badge. If you're interested, please claim your badge by filling out this form: Claim Your Zephyr Badge.

Thank you for your valuable input, and we look forward to seeing more of your contributions in the future! 🪁

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
area: Xtensa Xtensa Architecture platform: ESP32 Espressif ESP32 size: XS A PR changing only a single line of code
Projects
None yet
Development

Successfully merging this pull request may close these issues.

6 participants