-
Notifications
You must be signed in to change notification settings - Fork 6.9k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
issue #20654 #80643
issue #20654 #80643
Conversation
Hello @Ankush1oo8, and thank you very much for your first pull request to the Zephyr project! |
please use a more descpretive title |
Like how |
if possible can you edit
Cann you help with that please |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Some questions:
- How much of this did you personally write yourself?
- How familiar are you with the flash simulator driver?
- How accurate is the text in the PR?
Actually I am linux user and often in my college project i use the it for testing pupose |
Hi @Ankush1oo8 Thanks very much for the PR -- it is always nice to see people trying to help tackle some of the issues that have been open for a very long time. However, in this particular situation, I don't think just asking ChatGPT to document flash_simulator.c is getting us to the level of detail that is really helpful for someone to really learn about the capabilities of the simulator. As a thought, you may want to consider writing a new code sample that exercises Would you be interested in doing that? In any case you may want to have a look at our contribution guidelines and documentation writing guidelines (for example, the page you're proposing to add is not even "mounted" in the documentation's table of contents at the moment) Thanks! |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
No AI garbage please.
@Ankush1oo8 so I take it that you are not interested in iterating on this and possibly contributing a code sample (or an improved doc page?) |
I want to contribute but i dont know how can i do that |
I think I gave you some pointers/ideas above but let me know if you have specific questions |
Resolve issue #20654 and made a documentaion for flash simulator
if ihave made any mistakes please feel free to correct me