drivers: serial: fix potential overflow in fifo_fill and fifo_read

[ken4647]

try to fix issue #80599 , a error of type transform(?) in serial drivers. For fifo_read it may cause wrong read data if parameter size is over 255, while endless looping for fifo_fill, if uart is running faster than cpu.

Fixes #80599

[github-actions]

Hello @ken4647, and thank you very much for your first pull request to the Zephyr project!
Our Continuous Integration pipeline will execute a series of checks on your Pull Request commit messages and code, and you are expected to address any failures by updating the PR. Please take a look at our commit message guidelines to find out how to format your commit messages, and at our contribution workflow to understand how to update your Pull Request. If you haven't already, please make sure to review the project's Contributor Expectations and update (by amending and force-pushing the commits) your pull request if necessary.
If you are stuck or need help please join us on Discord and ask your question there. Additionally, you can escalate the review when applicable. 😊

[ycsin]

The patch looks fine but the your commit message doesn't meet our contribution guideline and the CI is going to fail, please take a look at https://docs.zephyrproject.org/latest/contribute/guidelines.html#commit-message-guidelines

Basically, you need something like this

drivers: serial: fix problem for a possible overflow in serial fifo_fill or fifo_read | <- this title is too long, max is 72 char, current is 86

commit message line 1                                                     | <- each line should be 75 chars or less
commit message line 2                                                     | <- each line should be 75 chars or less
..                                                                        | <- each line should be 75 chars or less
commit message line n                                                     | <- each line should be 75 chars or less

Signed-off-by: John Doe <[email protected]>

I guess you can change the title to be drivers: serial: fix potential overflow in fifo_fill and fifo_read

[ken4647]

drivers: serial: fix potential overflow in fifo_fill and fifo_read

Thanks, I didn't notice the length. I have re-push my commit with new legal commit message.

[jhedberg]

@ken4647 you still need an actual body to the commit message. You could just put the PR description there. In addition to that you also need a Signed-off-by line (git commit will auto-generate that for you when you pass -s to it).

[ken4647]

@ken4647 you still need an actual body to the commit message. You could just put the PR description there. In addition to that you also need a Signed-off-by line (git commit will auto-generate that for you when you pass -s to it).

Sorry, I noticed it yet. I will read the guideline seriously to avoid the mistake.

[gautierg-st]

For STM32, some other functions are also impacted by this change and should be updated.
Note that I only reviewed the STM32 driver.

[gautierg-st]

LGTM for STM32

[ken4647]

The latest push is to eliminate the notices from CI for meeting the clang-format.

[soburi]

LGTM for renesas_ra_sci.

[soburi]

@duynguyenxa
Please check drivers/serial/uart_renesas_ra8_sci_b.c.

[duynguyenxa]

LGTM for drivers/serial/uart_renesas_ra8_sci_b.c.

[mmahadevan108]

@dcpleung , can you help review

[github-actions]

Hi @ken4647!
Congratulations on getting your very first Zephyr pull request merged 🎉🥳. This is a fantastic achievement, and we're thrilled to have you as part of our community!

To celebrate this milestone and showcase your contribution, we'd love to award you the Zephyr Technical Contributor badge. If you're interested, please claim your badge by filling out this form: Claim Your Zephyr Badge.

Thank you for your valuable input, and we look forward to seeing more of your contributions in the future! 🪁