Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

boards: waveshare: rp2040_zero: Initial support #79447

Merged
merged 1 commit into from
Dec 3, 2024
Merged

boards: waveshare: rp2040_zero: Initial support #79447

merged 1 commit into from
Dec 3, 2024

Conversation

icpmoles
Copy link
Contributor

@icpmoles icpmoles commented Oct 5, 2024

Adds initial support for Waveshare RP2040-Zero

@github-actions GitHub Actions
Copy link

github-actions bot commented Oct 5, 2024

Hello @icpmoles, and thank you very much for your first pull request to the Zephyr project!
Our Continuous Integration pipeline will execute a series of checks on your Pull Request commit messages and code, and you are expected to address any failures by updating the PR. Please take a look at our commit message guidelines to find out how to format your commit messages, and at our contribution workflow to understand how to update your Pull Request. If you haven't already, please make sure to review the project's Contributor Expectations and update (by amending and force-pushing the commits) your pull request if necessary.
If you are stuck or need help please join us on Discord and ask your question there. Additionally, you can escalate the review when applicable. 😊

nordicjm
nordicjm requested changes Oct 7, 2024
View reviewed changes
Copy link
Collaborator

@nordicjm nordicjm left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please read https://docs.zephyrproject.org/latest/contribute/index.html

@zephyrbot zephyrbot added the area: ADC Analog-to-Digital Converter (ADC) label Oct 13, 2024
@zephyrbot zephyrbot requested a review from anangl October 13, 2024 06:22
@icpmoles icpmoles requested a review from nordicjm October 13, 2024 18:50
nordicjm
nordicjm requested changes Oct 17, 2024
View reviewed changes
boards/waveshare/rp2040_zero/Kconfig.defconfig Outdated Show resolved Hide resolved
boards/waveshare/rp2040_zero/Kconfig.defconfig Outdated
config RP2_FLASH_W25Q080
default y


Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change

boards/waveshare/rp2040_zero/Kconfig.defconfig Outdated
config I2C_DW_CLOCK_SPEED
default 125

endif #I2C_DW
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
endif #I2C_DW
endif # I2C_DW

boards/waveshare/rp2040_zero/Kconfig.defconfig Outdated
default 125

endif #I2C_DW

Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change

boards/waveshare/rp2040_zero/doc/img/RP2040-Zero-1.jpg Outdated Show resolved Hide resolved
boards/waveshare/rp2040_zero/doc/index.rst Outdated Show resolved Hide resolved
boards/waveshare/rp2040_zero/doc/index.rst Outdated
Using UF2
---------

Since it doesn’t expose the SWD pins, you must flash the RP2040-Zero with an UF2 file. By default, building an app for this board will generate a build/zephyr/zephyr.uf2 file. If the RP2040-Zero is powered on with the BOOTSEL button pressed, it will appear on the host as a mass storage device. The UF2 file should be drag-and-dropped to the device, which will flash the RP2040-Zero.
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

west flash should also work

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Can it work without the SWD pins exposed? For similarly shaped rp2040 boards that don't expose the debugger pins the Zephyr documentation only mention UF2 flashing.

Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

When you have a uf2 runner as the default, west flash will copy the uf2 file over, it has no need for SWD pins, they would only be used with runners that flash using that.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the explanation. I rewrote the section and now it mentions west flash and the manual drag-and-drop.

boards/waveshare/rp2040_zero/doc/index.rst Show resolved Hide resolved
boards/waveshare/rp2040_zero/rp2040_zero-pinctrl.dtsi Outdated Show resolved Hide resolved
boards/waveshare/rp2040_zero/Kconfig.defconfig Outdated Show resolved Hide resolved
@icpmoles icpmoles force-pushed the main branch 6 times, most recently from b1ac3a5 to aeb2208 Compare October 22, 2024 20:20
nordicjm
nordicjm reviewed Oct 25, 2024
View reviewed changes
Copy link
Collaborator

@nordicjm nordicjm left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Minor nit. and please add a message to the commit to fix compliance issue

boards/waveshare/rp2040_zero/Kconfig.rp2040_zero Outdated Show resolved Hide resolved
@kartben kartben requested review from soburi and yonsch October 26, 2024 08:28
@kartben kartben assigned soburi and unassigned anangl Oct 26, 2024
@icpmoles icpmoles requested a review from nordicjm November 1, 2024 13:33
nordicjm
nordicjm previously approved these changes Nov 4, 2024
View reviewed changes
soburi
soburi requested changes Nov 8, 2024
View reviewed changes
Copy link
Member

@soburi soburi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

code_partition has weird notation.

soburi
soburi previously approved these changes Nov 8, 2024
View reviewed changes
Copy link
Member

@soburi soburi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@soburi soburi requested a review from nordicjm November 19, 2024 10:14
@soburi
Copy link
Member

soburi commented Nov 24, 2024

@nordicjm
Could you revisit this PR?

nordicjm
nordicjm previously approved these changes Nov 25, 2024
View reviewed changes
kartben
kartben requested changes Nov 25, 2024
View reviewed changes
boards/waveshare/rp2040_zero/doc/index.rst Outdated Show resolved Hide resolved
boards/waveshare/rp2040_zero/doc/img/RP2040-Zero-M-1.png Outdated Show resolved Hide resolved
boards/waveshare/rp2040_zero/doc/img/RP2040-Zero-1.png Outdated Show resolved Hide resolved
boards/waveshare/rp2040_zero/doc/index.rst Outdated Show resolved Hide resolved
@icpmoles icpmoles dismissed stale reviews from nordicjm and soburi via 7cef478 November 25, 2024 17:35
@icpmoles icpmoles requested a review from kartben November 26, 2024 15:03
@icpmoles icpmoles force-pushed the main branch 2 times, most recently from 8f79949 to ce20579 Compare November 27, 2024 20:06
soburi
soburi previously approved these changes Nov 27, 2024
View reviewed changes
@icpmoles
boards: waveshare: rp2040_zero: Initial support
c31e4f7 
This PR adds supports for Waveshare RP2040 Zero

Signed-off-by: Iacopo Moles <[email protected]>
@kartben kartben merged commit bd69ae4 into zephyrproject-rtos:main Dec 3, 2024
18 checks passed
@github-actions GitHub Actions
Copy link

github-actions bot commented Dec 3, 2024

Hi @icpmoles!
Congratulations on getting your very first Zephyr pull request merged 🎉🥳. This is a fantastic achievement, and we're thrilled to have you as part of our community!

To celebrate this milestone and showcase your contribution, we'd love to award you the Zephyr Technical Contributor badge. If you're interested, please claim your badge by filling out this form: Claim Your Zephyr Badge.

Thank you for your valuable input, and we look forward to seeing more of your contributions in the future! 🪁

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@soburi soburi soburi approved these changes

@kartben kartben kartben approved these changes

@nordicjm nordicjm nordicjm left review comments

@anangl anangl Awaiting requested review from anangl

@yonsch yonsch Awaiting requested review from yonsch

Assignees

@soburi soburi

Labels
area: ADC Analog-to-Digital Converter (ADC) area: Boards area: Documentation platform: Raspberry Pi Pico Raspberry Pi Pico (RPi Pico)
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
6 participants
@icpmoles @soburi @kartben @nordicjm @anangl @zephyrbot