Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Backport v2.7] posix: sched: ensure min and max priority are schedulable #57414

Merged
merged 2 commits into from
May 2, 2023

Conversation

cfriedt
Copy link
Member

@cfriedt cfriedt commented Apr 30, 2023

Backport 2b2cbf8..ad71b78 from #57161

Fixes #56729

Previously, there was an off-by-one error for SCHED_RR.

Fixes #56729

Signed-off-by: Chris Friedt <[email protected]>
(cherry picked from commit 2b2cbf8)
@cfriedt cfriedt requested a review from pfalcon as a code owner April 30, 2023 12:22
@github-actions github-actions bot added area: POSIX POSIX API Library area: Tests Issues related to a particular existing or missing test labels Apr 30, 2023
@cfriedt cfriedt requested review from jgl-meta and nashif April 30, 2023 12:32
Verify that threads are actually schedulable for min and max
scheduler priority for both `SCHED_RR` (preemptive) and
`SCHED_FIFO` (cooperative).

Fixes #56729

Signed-off-by: Chris Friedt <[email protected]>
(cherry picked from commit ad71b78)
@cfriedt cfriedt force-pushed the backport-57161-to-v2.7-branch branch from cf9d0f8 to 347de78 Compare April 30, 2023 12:54
@cfriedt cfriedt changed the title Backport 57161 to v2.7 branch [Backport v2.7] posix: sched: ensure min and max priority are schedulable May 1, 2023
@cfriedt
Copy link
Member Author

cfriedt commented May 2, 2023

I would suggest merging this.

The test that is failing is due to #56163 which has been escalated to priority: high and is unrelated to this change.

===================================================================
START - test_posix_clock
POSIX clock APIs
ASSERTION FAIL [0] @ WEST_TOPDIR/zephyr/kernel/sched.c:1598
        aborted _current back from dead
E: r0/a1:  0x00000004  r1/a2:  0x0000063e  r2/a3:  0x00000000
E: r3/a4:  0x00006f5d r12/ip:  0x00000000 r14/lr:  0x00009ac7
E:  xpsr:  0x41000000
E: Faulting instruction address (r15/pc): 0x0000adf2
E: >>> ZEPHYR FATAL ERROR 4: Kernel panic on CPU 0
E: Current thread: 0x200004d0 (unknown)
E: Halting system

INFO    - /home/cfriedt/zephyrproject/zephyr/twister-out/mps2_an385/tests/posix/common/portability.posix.common.newlib/handler.log
INFO    - Total complete:   82/  82  100%  skipped:   99, failed:    1
INFO    - 77 of 78 test configurations passed (98.72%), 1 failed, 99 skipped with 0 warnings in 144.70 seconds
INFO    - In total 2496 test cases were executed, 3168 skipped on 21 out of total 394 platforms (5.33%)
INFO    - 55 test configurations executed on platforms, 23 test configurations were only built.
INFO    - Saving reports...
INFO    - Writing xunit report /home/cfriedt/zephyrproject/zephyr/twister-out/twister.xml...
INFO    - Writing xunit report /home/cfriedt/zephyrproject/zephyr/twister-out/twister_report.xml...
INFO    - Run completed

@cfriedt cfriedt self-assigned this May 2, 2023
@cfriedt cfriedt merged commit 9d2533f into v2.7-branch May 2, 2023
@nashif nashif deleted the backport-57161-to-v2.7-branch branch February 13, 2024 15:16
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
area: POSIX POSIX API Library area: Tests Issues related to a particular existing or missing test
Projects
Status: Done
Development

Successfully merging this pull request may close these issues.

3 participants