toolchain: Move extra warning options to toolchain abstraction #53305
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@evgeniy-paltsev, could you please send your feedback? |
kokas-a
force-pushed
the
arc_mwdt_warnings
branch
2 times, most recently
from
36fdebf to
add47ff
Compare
evgeniy-paltsev
requested changes
Dec 23, 2022
kokas-a
force-pushed
the
arc_mwdt_warnings
branch
from
add47ff to
7c4293e
Compare
kokas-a
force-pushed
the
arc_mwdt_warnings
branch
2 times, most recently
from
dc91184 to
5cc8144
Compare
evgeniy-paltsev
requested changes
Dec 27, 2022
There was a problem hiding this comment.
In this PR we provide flags only for GCC and ARCMWDT toolchain, but currently the flags values are selected for all toolchains.
So we need pt provide these default flags for all Zephyr supported toolchains (xcc, clang, etc...) to keep existing behavior for them.
kokas-a
force-pushed
the
arc_mwdt_warnings
branch
from
5cc8144 to
d3cf0eb
Compare
evgeniy-paltsev
previously approved these changes
Dec 28, 2022
evgeniy-paltsev
changed the title
zephyrbot
added
area: Build System
area: Toolchains
zephyrbot
requested review from
chen-png,
enjiamai,
galak,
gopiotr,
hakehuang,
jeremybettis,
nordicjm,
PerMac and
stephanosio
kokas-a
requested review from
evgeniy-paltsev,
abrodkin,
stephanosio and
tejlmand
and removed request for
tejlmand,
galak,
gopiotr,
hakehuang,
jeremybettis,
nashif,
nordicjm,
PerMac,
evgeniy-paltsev,
abrodkin and
stephanosio
abrodkin
approved these changes
Jan 26, 2023
stephanosio
approved these changes
Jan 26, 2023
|
@tejlmand Can you please take a look? |
evgeniy-paltsev
approved these changes
Jan 26, 2023
|
@tejlmand Could you please give your feedback to this PR? |
tejlmand
approved these changes
Feb 17, 2023
galak
approved these changes
Feb 17, 2023
This was referenced Dec 13, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Move extra warning option from generic twister script into compiler-dependent config files.
ARCMWDT compiler doesn't support extra warning options ex. "-Wl,--fatal-warnings". To avoid build fails flag
"disable_warnings_as_errors" should be passed to twister. This allows all warning messages and make atomatic test useles.
Signed-off-by: Nikolay Agishev [email protected]